Display the File age in preview panel #3578
Conversation
|
🥷 Code experts: Jack251970, Yusyuriv Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
📝 WalkthroughWalkthroughThe code update enhances the file preview panel by displaying both a relative and absolute timestamp for file creation and modification dates. A new private method calculates and returns a human-readable relative time, such as "Today" or "X days ago," which is then prepended to the existing formatted date display. Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Plugins/Flow.Launcher.Plugin.Explorer/Views/PreviewPanel.xaml.cs(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: gitStream.cm
🔇 Additional comments (2)
Plugins/Flow.Launcher.Plugin.Explorer/Views/PreviewPanel.xaml.cs (2)
69-74: LGTM! Clean implementation of relative date display for creation time.The logic correctly combines the relative time string with the formatted absolute date, providing users with both contextual and precise time information.
79-84: LGTM! Consistent implementation for last modified time.The implementation follows the same pattern as the creation date handling, maintaining consistency in the user interface.
| private string GetDiffTimeString(DateTime fileDateTime) | ||
| { | ||
| DateTime now = DateTime.Now; | ||
| TimeSpan difference = now - fileDateTime; | ||
|
|
||
| if (fileDateTime > now) | ||
| return "In the future"; | ||
|
|
||
| if (difference.TotalDays < 1) | ||
| return "Today"; | ||
| if (difference.TotalDays < 30) | ||
| return $"{(int)difference.TotalDays} days ago"; | ||
|
|
||
| int monthsDiff = (now.Year - fileDateTime.Year) * 12 + now.Month - fileDateTime.Month; | ||
| if (monthsDiff < 12) | ||
| return monthsDiff == 1 ? "1 month ago" : $"{monthsDiff} months ago"; | ||
|
|
||
| int yearsDiff = now.Year - fileDateTime.Year; | ||
| if (now.Month < fileDateTime.Month || (now.Month == fileDateTime.Month && now.Day < fileDateTime.Day)) | ||
| yearsDiff--; | ||
|
|
||
| return yearsDiff == 1 ? "1 year ago" : $"{yearsDiff} years ago"; | ||
| } |
There was a problem hiding this comment.
Fix pluralization issue and consider localization improvements.
The method has a grammatical error and could benefit from some improvements:
-
Critical Issue: Line 106 will display "1 days ago" instead of "1 day ago" when the file is exactly 1 day old.
-
Optional Improvements: Consider localization for international users and more precise day boundary handling.
Fix the pluralization bug:
- if (difference.TotalDays < 30)
- return $"{(int)difference.TotalDays} days ago";
+ if (difference.TotalDays < 30)
+ {
+ int days = (int)difference.TotalDays;
+ return days == 1 ? "1 day ago" : $"{days} days ago";
+ }Optional enhancement for better localization:
Consider extracting the hardcoded English strings to resource files to support multiple languages, as this feature enhances user experience and would benefit international users.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| private string GetDiffTimeString(DateTime fileDateTime) | |
| { | |
| DateTime now = DateTime.Now; | |
| TimeSpan difference = now - fileDateTime; | |
| if (fileDateTime > now) | |
| return "In the future"; | |
| if (difference.TotalDays < 1) | |
| return "Today"; | |
| if (difference.TotalDays < 30) | |
| return $"{(int)difference.TotalDays} days ago"; | |
| int monthsDiff = (now.Year - fileDateTime.Year) * 12 + now.Month - fileDateTime.Month; | |
| if (monthsDiff < 12) | |
| return monthsDiff == 1 ? "1 month ago" : $"{monthsDiff} months ago"; | |
| int yearsDiff = now.Year - fileDateTime.Year; | |
| if (now.Month < fileDateTime.Month || (now.Month == fileDateTime.Month && now.Day < fileDateTime.Day)) | |
| yearsDiff--; | |
| return yearsDiff == 1 ? "1 year ago" : $"{yearsDiff} years ago"; | |
| } | |
| private string GetDiffTimeString(DateTime fileDateTime) | |
| { | |
| DateTime now = DateTime.Now; | |
| TimeSpan difference = now - fileDateTime; | |
| if (fileDateTime > now) | |
| return "In the future"; | |
| if (difference.TotalDays < 1) | |
| return "Today"; | |
| if (difference.TotalDays < 30) | |
| { | |
| int days = (int)difference.TotalDays; | |
| return days == 1 ? "1 day ago" : $"{days} days ago"; | |
| } | |
| int monthsDiff = (now.Year - fileDateTime.Year) * 12 + now.Month - fileDateTime.Month; | |
| if (monthsDiff < 12) | |
| return monthsDiff == 1 ? "1 month ago" : $"{monthsDiff} months ago"; | |
| int yearsDiff = now.Year - fileDateTime.Year; | |
| if (now.Month < fileDateTime.Month | |
| || (now.Month == fileDateTime.Month && now.Day < fileDateTime.Day)) | |
| { | |
| yearsDiff--; | |
| } | |
| return yearsDiff == 1 ? "1 year ago" : $"{yearsDiff} years ago"; | |
| } |
🤖 Prompt for AI Agents
In Plugins/Flow.Launcher.Plugin.Explorer/Views/PreviewPanel.xaml.cs between
lines 95 and 117, fix the pluralization bug by ensuring that when the difference
in days is exactly 1, the method returns "1 day ago" instead of "1 days ago".
Additionally, for better localization support, extract all hardcoded English
strings into resource files to enable easy translation and adaptation for
international users.
1 participant
Issue: #3533
Examples: