Skip to content

Conversation

Jack251970
Copy link
Member

@Jack251970 Jack251970 commented May 29, 2025

Use ModernWPF successor iNKORE.UI.WPF.Modern

  • Introduce iNKORE.UI.WPF.Modern UI framework & remove plenty of unused resources.
  • Disable ImageCache to resolve WPF second window freezing issue.
  • Use ui:ScrollViewerEx to replace ScrollViewer to enable smooth scroll.
  • Fix main window scroll sensitivity issue.
  • Unify CanContentScroll design
  • Improve scroll bar position of setting window.
  • Improve plugin page loading speed.
  • Add UI.WPF.Modern in README.md. (It is really an excellent ui framework!!!)

Resolve #2890, #2129, etc.

TODO

Test

  • Memory usage
    • PC: Open App, Open App + Open Search Window, Open App + Open Search Window + Search Something + Open Setting Window
      Original: 615.2MB, 692.0MB, 716.7MB
      Upgraded: 616.4MB, 692.2MB, 732.5MB

TODO:

merge website PR 66 on release

This comment has been minimized.

This comment has been minimized.

@prlabeler prlabeler bot added the bug Something isn't working label May 29, 2025
@Jack251970 Jack251970 added the kind/ui related to UI, icons, themes, etc label May 29, 2025
@Jack251970 Jack251970 added this to the Future milestone May 29, 2025

This comment has been minimized.

@Jack251970 Jack251970 linked an issue Jun 2, 2025 that may be closed by this pull request
2 tasks
@Jack251970 Jack251970 mentioned this pull request Jun 2, 2025
1 task
@Jack251970 Jack251970 linked an issue Jun 3, 2025 that may be closed by this pull request
2 tasks
@Jack251970 Jack251970 linked an issue Jun 3, 2025 that may be closed by this pull request
2 tasks
@Jack251970 Jack251970 added enhancement New feature or request and removed bug Something isn't working labels Jun 4, 2025
@prlabeler prlabeler bot added the bug Something isn't working label Jun 5, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Oct 5, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 2
⚠️ noisy-file 1
⚠️ non-alpha-in-dictionary 2

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 enabled auto-merge (squash) October 5, 2025 10:28
@jjw24 jjw24 removed bug Something isn't working review in progress Indicates that a review is in progress for this PR 20 min review labels Oct 5, 2025
@jjw24 jjw24 merged commit 5ae159d into dev Oct 5, 2025
6 checks passed
@jjw24 jjw24 deleted the ui_wpf_modern branch October 5, 2025 10:44
@prlabeler prlabeler bot added the bug Something isn't working label Oct 5, 2025
@jjw24 jjw24 removed the bug Something isn't working label Oct 5, 2025
@prlabeler prlabeler bot added the bug Something isn't working label Oct 5, 2025
@jjw24 jjw24 removed the bug Something isn't working label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment