-
-
Notifications
You must be signed in to change notification settings - Fork 453
Add crowdin contribution tip to readme #3614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🥷 Code experts: Yusyuriv, jjw24 Yusyuriv, jjw24 have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
This comment has been minimized.
This comment has been minimized.
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughA "Localization" subsection was added to the "Development" section of the README.md file, explaining that localization is managed via Crowdin and providing a direct link for contributors to access the Crowdin project page for Flow Launcher. Changes
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
378-381: Replace bare URL with proper markdown link and refine phrasingThe static analysis flagged a bare URL and the sentence can be clearer.
- Our project localization is based on [Crowdin](https://crowdin.com). If you would like to change them, please go to https://crowdin.com/project/flow-launcher. + Our project's localization is managed via [Crowdin](https://crowdin.com). To contribute translations, please visit the [Crowdin project page](https://crowdin.com/project/flow-launcher).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
380-380: Bare URL used
null(MD034, no-bare-urls)
378-381: Consider discouraging direct XAML editsIt may be helpful to add a note advising contributors not to modify XAML files directly, and to route all localization through Crowdin to prevent merge conflicts and maintain consistency.
### Localization Our project's localization is managed via [Crowdin](https://crowdin.com). To contribute translations, please visit the [Crowdin project page](https://crowdin.com/project/flow-launcher). + + > **Note:** Do not edit localization XAML files directly in the repository. Submit all translation changes through Crowdin to keep translations synchronized.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
380-380: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
380-380: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: gitStream workflow automation
- GitHub Check: gitStream.cm
- GitHub Check: build
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. Pattern suggestions ✂️ (1)You could add these patterns to Alternatively, if a pattern suggestion doesn't make sense for this project, add a If the flagged items are 🤯 false positivesIf items relate to a ...
|
Since there are plenty of PRs about changing the xaml language files like #3613 and #3601, we should tell them how to contribute to localization