Add PendingLineStyle in Base.xaml to fix ResourceReferenceKeyNotFoundException

[onesounds]

What's the PR

• Fix ResourceReferenceKeyNotFoundException: 'PendingLineStyle' resource not found. #3618
• Added a default PendingLine style key to the base style to prevent errors when the key is missing.
• If the theme provides its own PendingLine style, that will be applied instead.

ETC

• No other changes were made that could cause such an issue. Upon reviewing the code, the only modification related to Pending was changing its default color from blue to the system accent color. The issue is likely caused by a missing style key when using a custom theme.

Test Cases

• Flow should not throw an error when the PendingLine style is missing from the theme.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[coderabbitai]

📝 Walkthrough

Walkthrough

A new style resource named "PendingLineStyle" has been added to the WPF application's resource dictionary. This style is based on the existing "BasePendingLineStyle" and targets the Line element, addressing a missing resource reference issue.

Changes

File(s)	Change Summary
Flow.Launcher/Themes/Base.xaml	Added "PendingLineStyle" style for Line elements based on "BasePendingLineStyle".

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant ResourceDictionary
    participant UI

    App->>ResourceDictionary: Request "PendingLineStyle"
    ResourceDictionary-->>App: Return "PendingLineStyle" (now defined)
    App->>UI: Render Line with "PendingLineStyle"

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Define and include "PendingLineStyle" resource to resolve ResourceReferenceKeyNotFoundException (#3618)	✅
Ensure fix does not introduce regressions in resource management or UI rendering (#3618)	✅
Maintain compatibility with .NET 7.0 and current Flow Launcher version (#3618)	✅

Suggested reviewers

• taooceros

Poem

In the world of XAML, a style went astray,
"PendingLineStyle" was missing—oh, what a day!
Now it's returned, based on what came before,
No more exceptions, the app can restore.
A hop and a jump, the UI’s just fine—
Thanks to a rabbit, your code’s in line! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93c2b1b and 2f9e7e1.

📒 Files selected for processing (1)

• Flow.Launcher/Themes/Base.xaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: gitStream.cm

🔇 Additional comments (1)

Flow.Launcher/Themes/Base.xaml (1)

111-114:

✅ Verification successful

LGTM! This correctly provides the missing default style key.

The implementation follows established patterns in the codebase and provides a fallback style that custom themes can override. This should resolve the errors when PendingLineStyle is referenced but not defined in custom themes.

Let me verify that this style is actually being referenced elsewhere in the codebase:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify that PendingLineStyle is referenced in the codebase
# Expected: Find usages of PendingLineStyle in XAML or code files

# Search for PendingLineStyle references
rg -i "pendinglinestyle" --type xml --type cs --type xaml -A 2 -B 2

# Also search for any Line elements that might use this style
rg "Style.*PendingLine" --type xml --type xaml -A 2 -B 2

Length of output: 184

---

Let's broaden the search to include .xaml and .cs files via glob patterns rather than relying on unsupported “xaml” filetype:

---

🏁 Script executed:

#!/bin/bash
# Verify PendingLineStyle usages in .xaml and .cs files

# 1. Search for references to PendingLineStyle
rg -i "PendingLineStyle" -g '*.xaml' -g '*.cs' -A2 -B2

# 2. Search for any Style attributes targeting PendingLine
rg -i "Style.*PendingLine" -g '*.xaml' -g '*.cs' -A2 -B2

Length of output: 10019

---

Approve: PendingLineStyle references verified across themes and code

All expected references to PendingLineStyle have been found in theme XAML files and in MainWindow.xaml.cs, confirming the new style key is consumed throughout the application. No further changes needed.

• Multiple theme files (e.g., BlurWhite.xaml, Ubuntu.xaml, Sublime.xaml, etc.) define or inherit from PendingLineStyle.
• MainWindow.xaml.cs uses FindResource("PendingLineStyle") when constructing the progress animation’s Line style.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

onesounds has most 👩‍💻 activity in the files.
onesounds has most 🧠 knowledge in the files.

See details

Flow.Launcher/Themes/Base.xaml

Activity based on git-commit:

	onesounds
JUN	4 additions & 0 deletions
MAY
APR	8 additions & 0 deletions
MAR	65 additions & 62 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 70%

To learn more about /:\ gitStream - Visit our Docs