Fix Program plugin to not show dialog when unable to resolve Lnk shortcuts

[Jack251970]

Use SLR_NO_UI to avoid showing any UI during link resolving, like Problem with Shortcut dialogs
From: https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishelllinka-resolve

Resolve #3386.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, VictoriousRaptor have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs

Activity based on git-commit:

	Jack251970
JUN
MAY
APR
MAR
FEB
JAN

Knowledge based on git-blame:
Jack251970: 33%
VictoriousRaptor: 18%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[Copilot]

Pull Request Overview

This PR prevents UI dialogs when resolving Windows shortcuts by using the SLR_NO_UI flag and exposes the helper class for broader use.

• Made ShellLinkHelper public
• Added SLR_NO_UI to IShellLinkW.Resolve to suppress UI
• Included MSDN reference comment for the flag

Comments suppressed due to low confidence (3)

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs:11

• Since ShellLinkHelper is now a public class, add an XML doc comment summarizing its purpose and usage.

public class ShellLinkHelper

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs:27

• Public methods should use PascalCase. Rename retrieveTargetPath to RetrieveTargetPath for consistency.

public unsafe string retrieveTargetPath(string path)

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs:32

• Consider adding a unit test to confirm that using SLR_NO_UI suppresses UI dialogs when resolution fails.

((IShellLinkW)link).Resolve(hwnd, (uint)SLR_FLAGS.SLR_NO_UI);

[coderabbitai]

📝 Walkthrough

Walkthrough

The ShellLinkHelper class was made public, and its retrieveTargetPath method was updated to use the SLR_NO_UI flag when resolving shell links, preventing UI dialogs from appearing during shortcut resolution. Minor whitespace cleanup was also performed.

Changes

File(s)	Change Summary
Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs	Changed class visibility to public; updated IShellLinkW.Resolve call to use SLR_NO_UI flag; minor whitespace cleanup.

Sequence Diagram(s)

sequenceDiagram
    participant Indexer
    participant ShellLinkHelper
    participant IShellLinkW

    Indexer->>ShellLinkHelper: retrieveTargetPath(shortcut)
    ShellLinkHelper->>IShellLinkW: Resolve(shortcut, SLR_NO_UI)
    IShellLinkW-->>ShellLinkHelper: Return resolved path or error (no UI)
    ShellLinkHelper-->>Indexer: Return target path

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Prevent UI dialogs from appearing when resolving broken shortcuts during background indexing (#3386)	✅

Suggested labels

bug

Suggested reviewers

• taooceros
• jjw24

Poem

A shortcut once broken would pop up with a frown,
But now Flow is silent, no dialogs around.
With a flag set just right,
No more pop-ups at night—
The launcher is peaceful, the bugs have gone down!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf98a73 and 08c8b8c.

📒 Files selected for processing (1)

• Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: build

🔇 Additional comments (2)

Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs (2)

30-32: Excellent implementation of the core PR objective.

The addition of the SLR_NO_UI flag with comprehensive documentation comments perfectly addresses the PR objective of preventing UI dialogs during shortcut resolution. The Microsoft documentation reference is a great addition for context and maintainability.

---

83-83: Good housekeeping with the whitespace cleanup.

Minor formatting improvement with no functional impact.

[Jack251970]

Already tested by users and good to go.

[jjw24]

👍