Fix index out of range error for FireFox bookmarks loading

Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs

@@ -24,10 +24,10 @@
 
     // Updated query - removed favicon_id column
     private const string QueryAllBookmarks = """
         SELECT moz_places.url, moz_bookmarks.title
         FROM moz_places
             INNER JOIN moz_bookmarks ON (
                 moz_bookmarks.fk NOT NULL AND moz_bookmarks.title NOT NULL AND moz_bookmarks.fk = moz_places.id
             )
         ORDER BY moz_places.visit_count DESC
         """;
@@ -80,12 +80,12 @@
             // Load favicons after loading bookmarks
             if (Main._settings.EnableFavicons)
             {
                 var faviconDbPath = Path.Combine(Path.GetDirectoryName(placesPath), "favicons.sqlite");
                 if (File.Exists(faviconDbPath))
                 {
                     Main._context.API.StopwatchLogInfo(ClassName, $"Load {bookmarks.Count} favicons cost", () =>
                     {
                         LoadFaviconsFromDb(faviconDbPath, bookmarks);
                     });
                 }
             }
@@ -116,7 +116,7 @@
         return bookmarks;
     }
 
     private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
     {
         // Use a copy to avoid lock issues with the original file
         var tempDbPath = Path.Combine(_faviconCacheDir, $"tempfavicons_{Guid.NewGuid()}.sqlite");
@@ -147,7 +147,7 @@
             // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
             var savedPaths = new ConcurrentDictionary<string, bool>();
 
             // Get favicons based on bookmarks concurrently
             Parallel.ForEach(bookmarks, bookmark =>
             {
                 // Use read-only connection to avoid locking issues
@@ -198,7 +198,7 @@
                         faviconPath = Path.Combine(_faviconCacheDir, $"firefox_{domain}.png");
                     }
 
                     // Filter out duplicate favicons
                     if (savedPaths.TryAdd(faviconPath, true))
                     {
                         SaveBitmapData(imageData, faviconPath);
@@ -270,6 +270,7 @@
     /// <summary>
     /// Path to places.sqlite
     /// </summary>
+    /// <remarks></remarks>
     private static string PlacesPath
     {
         get
@@ -295,12 +296,50 @@
 
             var indexOfDefaultProfileAttributePath = lines.IndexOf("Path=" + defaultProfileFolderName);
 
+            /*
+                Current profiles.ini structure example as of Firefox version 69.0.1
+
+                [Install736426B0AF4A39CB]
+                Default=Profiles/7789f565.default-release   <== this is the default profile this plugin will get the bookmarks from. When opened Firefox will load the default profile
+                Locked=1
+
+                [Profile2]
+                Name=newblahprofile
+                IsRelative=0
+                Path=C:\t6h2yuq8.newblahprofile  <== Note this is a custom location path for the profile user can set, we need to cater for this in code.
+
+                [Profile1]
+                Name=default
+                IsRelative=1
+                Path=Profiles/cydum7q4.default
+                Default=1
+
+                [Profile0]
+                Name=default-release
+                IsRelative=1
+                Path=Profiles/7789f565.default-release
+
+                [General]
+                StartWithLastProfile=1
+                Version=2
+            */
             // Seen in the example above, the IsRelative attribute is always above the Path attribute
+
+            var relativePath = Path.Combine(defaultProfileFolderName, "places.sqlite");
+            var absoluePath = Path.Combine(profileFolderPath, relativePath);
+
+            // If the index is out of range, it means that the default profile is in a custom location or the file is malformed
+            // If the profile is in a custom location, we need to check 
+            if (indexOfDefaultProfileAttributePath - 1 < 0 ||
+                indexOfDefaultProfileAttributePath - 1 >= lines.Count)
+            {
+                return Directory.Exists(absoluePath) ? absoluePath : relativePath;
+            }
+
             var relativeAttribute = lines[indexOfDefaultProfileAttributePath - 1];
 
             return relativeAttribute == "0" // See above, the profile is located in a custom location, path is not relative, so IsRelative=0
-                ? defaultProfileFolderName + @"\places.sqlite"
-                : Path.Combine(profileFolderPath, defaultProfileFolderName) + @"\places.sqlite";
+                ? relativePath : absoluePath;
         }
     }
 }