Replace TabControl with Expander in Explorer Plugin Setting Panel to fix issue with scaling greater than 125% #3666

onesounds · 2025-06-06T08:07:06Z

What's the PR

Fix BUG: System.IndexOutOfRangeException: 'Index was outside the bounds of the array.' Issue in Explorer Settings Panel #3292
This issue is reportedly due to a known WPF bug related to TabControl. I’ve adjusted the structure by removing the TabControl altogether.

gitstream-cm · 2025-06-06T08:59:55Z

🥷 Code experts: Jack251970, jjw24

Jack251970 has most 👩‍💻 activity in the files.
jjw24, Jack251970 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml

Activity based on git-commit:

	Jack251970
JUN
MAY
APR	5 additions & 5 deletions
MAR	2066 additions & 1972 deletions
FEB
JAN

Knowledge based on git-blame:
Jack251970: 89%
jjw24: 1%

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs

Activity based on git-commit:

	Jack251970
JUN
MAY
APR	3 additions & 9 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
jjw24: 55%
Jack251970: 3%

To learn more about /:\ gitStream - Visit our Docs

gitstream-cm · 2025-06-06T09:00:03Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

coderabbitai · 2025-06-06T09:01:50Z

📝 Walkthrough

Walkthrough

The ExplorerSettings UI was refactored from a TabControl-based layout to an accordion-style interface using Expander controls. Supporting code was updated to manage expanders, enforce single expansion, and move sorting logic to load events. No changes to data bindings or public APIs were made; all updates are internal to the settings view and its code-behind.

Changes

File(s)	Change Summary
Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml	Replaced TabControl with StackPanel of Expander controls; added custom Expander style; reorganized settings into accordion sections; updated layout and event handlers.
Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs	Introduced expander management for single expansion; moved sorting logic to load events; standardized view model field usage; added event handlers for expanders and list loading.
Flow.Launcher/Resources/CustomControlTemplate.xaml	Added new style `ExpanderHeaderRightArrowStyle` for ToggleButton with custom arrow visuals and state triggers for expanders.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ExplorerSettings (UI)
    participant Expander
    participant SettingsViewModel

    User->>ExplorerSettings (UI): Opens Explorer Settings
    ExplorerSettings (UI)->>Expander: Renders multiple expanders (accordion)
    User->>Expander: Expands a section
    Expander->>ExplorerSettings (UI): Expander_Expanded event
    ExplorerSettings (UI)->>Expander: Collapse other expanders
    User->>ListView: Triggers Loaded event (AccessLinks/ExcludedPaths)
    ListView->>ExplorerSettings (UI): lbxAccessLinks_Loaded/lbxExcludedPaths_Loaded
    ExplorerSettings (UI)->>ListView: Apply sorting
    User->>SettingsViewModel: Interacts with settings (bindings unchanged)

Assessment against linked issues

Objective	Addressed	Explanation
Fix crash caused by System.IndexOutOfRangeException in Explorer Settings TabControl under high DPI (#3292)	✅
Ensure settings window and controls render correctly at small sizes and high DPI scaling (#3292)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.

Suggested reviewers

Jack251970

Poem

In the garden of code, a new layout appears,
Tabs have hopped away, as the accordion cheers.
Expanders now bloom, one open at a time,
No more crashes or bugs—just settings sublime!
With a wiggle of whiskers and a satisfied sigh,
This rabbit says: "Accordion, oh my!" 🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🔭 Outside diff range comments (1)

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs (1)
83-83: ⚠️ Potential issue

Fix inconsistent parameter name.

The parameter name should be "IndexSearchExcludedPaths" (plural) to match the convention used elsewhere in the codebase.

Apply this diff to fix the parameter name:
-    AccessLinkDragDrop("IndexSearchExcludedPath", e);
+    AccessLinkDragDrop("IndexSearchExcludedPaths", e);

🧹 Nitpick comments (2)

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml (1)

104-104: Consider using proper styling instead of negative margins.

The negative margin hack to extend separators to borders could be replaced with proper Border or Grid styling to achieve the same visual effect more maintainably.
Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs (1)
95-96: Remove unnecessary null check.

The _expanders field is initialized as new() on line 18, so it will never be null. The null check is redundant.

Apply this diff to simplify the code:
-    // Ensure _expanders is not null and contains items
-    if (_expanders == null || !_expanders.Any()) return;
+    // Ensure _expanders contains items
+    if (!_expanders.Any()) return;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d3888f and 569cb8b.

📒 Files selected for processing (2)

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml (1 hunks)
Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs (1)

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs (1)

AppendLink (319-328)

🪛 GitHub Check: Check Spelling

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml

[warning] 731-731:
Lbx is not a recognized word. (unrecognized-spelling)

[warning] 730-730:
lbx is not a recognized word. (unrecognized-spelling)

[warning] 727-727:
lbx is not a recognized word. (unrecognized-spelling)

[warning] 667-667:
lbx is not a recognized word. (unrecognized-spelling)

[warning] 663-663:
lbx is not a recognized word. (unrecognized-spelling)

[warning] 440-440:
previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 436-436:
previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 432-432:
previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 425-425:
previewpanel is not a recognized word. (unrecognized-spelling)

🪛 GitHub Actions: Check Spelling

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml

[warning] 425-425: Spell check warning: previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 432-432: Spell check warning: previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 436-436: Spell check warning: previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 440-440: Spell check warning: previewpanel is not a recognized word. (unrecognized-spelling)

[warning] 663-663: Spell check warning: lbx is not a recognized word. (unrecognized-spelling)

[warning] 667-667: Spell check warning: lbx is not a recognized word. (unrecognized-spelling)

[warning] 727-727: Spell check warning: lbx is not a recognized word. (unrecognized-spelling)

[warning] 730-730: Spell check warning: lbx is not a recognized word. (unrecognized-spelling)

[warning] 731-731: Spell check warning: Lbx is not a recognized word. (unrecognized-spelling)

[warning] 77-77: Spell check warning: Lbx is not a recognized word. (unrecognized-spelling)

[warning] 81-81: Spell check warning: Lbx is not a recognized word. (unrecognized-spelling)

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs