BrowserBookmark do not use SqliteConnection pooling to avoid ObjectDisposedException

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -52,14 +52,14 @@
             var profileBookmarks = LoadBookmarksFromFile(bookmarkPath, source);
 
             // Load favicons after loading bookmarks
             if (Main._settings.EnableFavicons)
             {
                 var faviconDbPath = Path.Combine(profile, "Favicons");
                 if (File.Exists(faviconDbPath))
                 {
                     Main._context.API.StopwatchLogInfo(ClassName, $"Load {profileBookmarks.Count} favicons cost", () =>
                     {
                         LoadFaviconsFromDb(faviconDbPath, profileBookmarks);
                     });
                 }
             }
@@ -129,7 +129,7 @@
         }
     }
 
     private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
     {
         // Use a copy to avoid lock issues with the original file
         var tempDbPath = Path.Combine(_faviconCacheDir, $"tempfavicons_{Guid.NewGuid()}.db");
@@ -155,12 +155,15 @@
             return;
         }
 
+        // Cache connection for pool clean
+        SqliteConnection connection1 = null;
+
         try
         {
             // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
             var savedPaths = new ConcurrentDictionary<string, bool>();
 
             // Get favicons based on bookmarks concurrently
             Parallel.ForEach(bookmarks, bookmark =>
             {
                 // Use read-only connection to avoid locking issues
@@ -181,7 +184,7 @@
                     using var cmd = connection.CreateCommand();
                     cmd.CommandText = @"
                             SELECT f.id, b.image_data
                             FROM favicons f
                             JOIN favicon_bitmaps b ON f.id = b.icon_id
                             JOIN icon_mapping m ON f.id = m.icon_id
                             WHERE m.page_url LIKE @url
@@ -202,7 +205,7 @@
 
                     var faviconPath = Path.Combine(_faviconCacheDir, $"chromium_{domain}_{iconId}.png");
 
                     // Filter out duplicate favicons
                     if (savedPaths.TryAdd(faviconPath, true))
                     {
                         SaveBitmapData(imageData, faviconPath);
@@ -216,8 +219,9 @@
                 }
                 finally
                 {
-                    // https://github.com/dotnet/efcore/issues/26580
-                    SqliteConnection.ClearPool(connection);
+                    // Cache connection and clear pool after all operations to avoid issue:
+                    // ObjectDisposedException: Safe handle has been closed.
+                    connection1 = connection;
                     connection.Close();
                     connection.Dispose();
                 }
@@ -231,6 +235,11 @@
         // Delete temporary file
         try
         {
+            // https://github.com/dotnet/efcore/issues/26580
+            if (connection1 != null)
+            {
+                SqliteConnection.ClearPool(connection1);
+            }
             File.Delete(tempDbPath);
         }
         catch (Exception ex)

Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs

@@ -24,8 +24,8 @@
 
     // Updated query - removed favicon_id column
     private const string QueryAllBookmarks = """
         SELECT moz_places.url, moz_bookmarks.title
         FROM moz_places
             INNER JOIN moz_bookmarks ON (
                 moz_bookmarks.fk NOT NULL AND moz_bookmarks.title NOT NULL AND moz_bookmarks.fk = moz_places.id
             )
@@ -142,6 +142,9 @@
             return;
         }
 
+        // Cache connection for pool clean
+        SqliteConnection connection1 = null;
+
         try
         {
             // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
@@ -212,8 +215,9 @@
                 }
                 finally
                 {
-                    // https://github.com/dotnet/efcore/issues/26580
-                    SqliteConnection.ClearPool(connection);
+                    // Cache connection and clear pool after all operations to avoid issue:
+                    // ObjectDisposedException: Safe handle has been closed.
+                    connection1 = connection;
                     connection.Close();
                     connection.Dispose();
                 }
@@ -227,6 +231,11 @@
         // Delete temporary file
         try
         {
+            // https://github.com/dotnet/efcore/issues/26580
+            if (connection1 != null)
+            {
+                SqliteConnection.ClearPool(connection1);
+            }
             File.Delete(tempDbPath);
         }
         catch (Exception ex)