Skip to content

Conversation

onesounds
Copy link
Contributor

What's the PR

Comment

  • This is something we've postponed before, but we really should make it user-configurable. For now, since it's a hassle to implement, let's just go with this...

@prlabeler prlabeler bot added the bug Something isn't working label Jun 9, 2025
@onesounds onesounds self-assigned this Jun 9, 2025
@onesounds onesounds added the kind/ui related to UI, icons, themes, etc label Jun 9, 2025

This comment has been minimized.

Copy link
Contributor

coderabbitai bot commented Jun 9, 2025

📝 Walkthrough

Walkthrough

The static array of recognized media file extensions in ResultManager.cs was expanded from 10 to 16 entries, adding support for ".m4a", ".m4v", ".heic", ".mov", ".flv", and ".webm". No other logic, control flow, or method signatures were altered in this update.

Changes

File(s) Change Summary
Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs Expanded MediaExtensions array with six additional media file extensions.

Assessment against linked issues

Objective Addressed Explanation
Ensure preview panel recognizes and expands previews for m4a, m4v, heic, mov, flv file types (#3653)

Suggested labels

Dev branch only

Poem

In the warren of code, new formats appear,
Now .m4a and .mov hop in with cheer!
.heic and .flv, .webm join the spree,
Previews grow larger—what a sight to see!
A rabbit’s delight, more files to explore,
With each extension, Flow Launches more!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f10f4a and a3f98a6.

📒 Files selected for processing (1)
  • Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
  • GitHub Check: Check Spelling
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs (5)

352-356: Use a HashSet for faster extension lookups
Replacing the array with a HashSet<string> (using StringComparer.OrdinalIgnoreCase) yields O(1) containment checks and will scale better as you add more extensions.

-private static readonly string[] MediaExtensions = 
-{
-    ".jpg", ".png", ".avi", ".mkv", ".bmp", ".gif", ".wmv", ".mp3", ".flac", ".mp4",
-    ".m4a", ".m4v", ".heic", ".mov", ".flv", ".webm"
-};
+private static readonly HashSet<string> MediaExtensions = new(StringComparer.OrdinalIgnoreCase)
+{
+    ".jpg", ".png", ".avi", ".mkv", ".bmp", ".gif", ".wmv", ".mp3", ".flac", ".mp4",
+    ".m4a", ".m4v", ".heic", ".mov", ".flv", ".webm"
+};

352-356: Add unit tests for new media types
There are currently no tests verifying that IsMedia recognizes .m4a, .m4v, .heic, .mov, .flv, and .webm. Please add coverage to prevent regressions.

Let me know if you’d like a test scaffold.


352-356: Consider externalizing the extension list
A hard-coded array makes updates and user customization harder. In the future, moving these values into plugin settings or a JSON config would be more flexible.


352-356: Sort extensions alphabetically for maintainability
Alphabetical order improves readability when the list grows.

-    ".jpg", ".png", ".avi", /*...*/, ".flv", ".webm"
+    ".avi", ".bmp", ".flac", /*...*/, ".mkv", ".webm"

352-356: Verify coverage of other common formats
Formats like .wav, .ogg, or .webp aren’t included. If preview support is desired for those, consider adding them now.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a4b4de and 8f10f4a.

📒 Files selected for processing (1)
  • Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
  • GitHub Check: Check Spelling

Copy link

gitstream-cm bot commented Jun 9, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Jack251970
Jack251970 previously approved these changes Jun 9, 2025
@onesounds onesounds enabled auto-merge June 9, 2025 07:10
@Jack251970 Jack251970 added this to the 1.20.1 milestone Jun 9, 2025
Copy link

gitstream-cm bot commented Jun 9, 2025

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
jjw24, Jack251970 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs

Activity based on git-commit:

Jack251970
JUN 97 additions & 55 deletions
MAY
APR 10 additions & 12 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
jjw24: 19%
Jack251970: 17%

To learn more about /:\ gitStream - Visit our Docs

Copy link

github-actions bot commented Jun 9, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@onesounds onesounds merged commit 680c6cc into Flow-Launcher:dev Jun 9, 2025
7 checks passed
jjw24 added a commit that referenced this pull request Jun 11, 2025
Add additional media file extensions for Preview
jjw24 added a commit that referenced this pull request Jun 11, 2025
Add additional media file extensions for Preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/ui related to UI, icons, themes, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Preview Image Size Issue in Preview Panel

2 participants