Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Jun 9, 2025

What's the PR

Always Preview Hotkey

  • Fix Binding

Before
image

After
image

Welcome Window Size

  • Increase the overall vertical height (+50) of the window and change the title element to wrap text automatically.

Before
image

After
image

Hotkey Dialog Button Size

  • Increase Button Size

Before
image

After
image

@prlabeler prlabeler bot added the bug Something isn't working label Jun 9, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@onesounds onesounds added the kind/ui related to UI, icons, themes, etc label Jun 9, 2025
@onesounds onesounds marked this pull request as ready for review June 9, 2025 03:25
Copy link
Contributor

coderabbitai bot commented Jun 9, 2025

📝 Walkthrough

Walkthrough

The changes primarily adjust layout properties, sizing, and text wrapping behaviors across several XAML files related to dialogs and welcome pages. Button heights, margins, grid row heights, and scrollability are updated to improve UI consistency. Tooltip binding for a settings card was changed from a static resource to a view model property with corresponding property change notification added. No control flow or exported/public entity declarations are affected.

Changes

File(s) Change Summary
Flow.Launcher/HotkeyControlDialog.xaml Adjusted button panel margin and replaced fixed button heights with minimum heights.
Flow.Launcher/WelcomeWindow.xaml Increased window height and its min/max constraints from 650 to 700 units.
Flow.Launcher/Resources/Pages/WelcomePage1.xaml Set explicit grid and canvas heights; enabled text wrapping for title TextBlock.
Flow.Launcher/Resources/Pages/WelcomePage2.xaml Set explicit grid row height; wrapped content in ScrollViewer; enabled text wrapping for title.
Flow.Launcher/Resources/Pages/WelcomePage4.xaml Enabled text wrapping for the title TextBlock.
Flow.Launcher/Resources/Pages/WelcomePage5.xaml Set explicit grid row height; adjusted margins; enabled text wrapping for title; spacing tweaks.
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml, SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs Changed tooltip property binding from static resource to view model property; added property change notification.

Possibly related PRs

  • Use dynamic resource instead of binding #3610: Reversed the tooltip binding approach for the "AlwaysPreview" card control, switching from binding to a dynamic resource to binding to a view model property with manual property change notification.

Suggested labels

kind/i18n

Suggested reviewers

  • onesounds
  • jjw24

Poem

A hop and a skip through XAML fields,
With buttons grown tall and titles that yield.
Scrollbars appear where content may sprawl,
Welcome grows wider—no detail too small!
Wrapping our words, margins aligned—
A rabbit’s delight in the code you’ve refined.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fac98d and f75a11c.

📒 Files selected for processing (2)
  • Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs (1 hunks)
  • Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (1)
Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs (1)

180-181: LGTM! Proper implementation of property change notification for multilingual binding.

The manual OnPropertyChanged call correctly addresses the UI refresh requirement when using direct property binding instead of DynamicResource. This ensures the AlwaysPreviewToolTip updates when the language changes, which aligns with the PR's multilingual display improvements.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970 Jack251970 added this to the 1.20.1 milestone Jun 9, 2025
Copy link

github-actions bot commented Jun 9, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented Jun 9, 2025

🥷 Code experts: Jack251970

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/HotkeyControlDialog.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 23 additions & 23 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
onesounds: 54%
Jack251970: 14%

Flow.Launcher/Resources/Pages/WelcomePage1.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 7 additions & 7 deletions
MAR 2 additions & 2 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 95%
Jack251970: 4%

Flow.Launcher/Resources/Pages/WelcomePage2.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 6 additions & 6 deletions
MAR 1 additions & 1 deletions 1 additions & 2 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 92%
Jack251970: 6%

Flow.Launcher/Resources/Pages/WelcomePage4.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 8 additions & 8 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
onesounds: 93%
Jack251970: 6%

Flow.Launcher/Resources/Pages/WelcomePage5.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 5 additions & 5 deletions
MAR 3 additions & 3 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 94%
Jack251970: 4%

Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs

Activity based on git-commit:

onesounds Jack251970
JUN
MAY 15 additions & 4 deletions
APR 355 additions & 225 deletions 64 additions & 137 deletions
MAR 77 additions & 55 deletions
FEB 17 additions & 8 deletions
JAN 33 additions & 3 deletions

Knowledge based on git-blame:
Jack251970: 27%
onesounds: 16%

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Activity based on git-commit:

onesounds Jack251970
JUN 1 additions & 1 deletions
MAY 40 additions & 11 deletions
APR 130 additions & 69 deletions 11 additions & 8 deletions
MAR 43 additions & 62 deletions 44 additions & 20 deletions
FEB 1 additions & 1 deletions
JAN 8 additions & 1 deletions

Knowledge based on git-blame:
onesounds: 62%
Jack251970: 14%

Flow.Launcher/WelcomeWindow.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 6 additions & 8 deletions
MAR 15 additions & 10 deletions
FEB 1 additions & 4 deletions
JAN

Knowledge based on git-blame:
onesounds: 92%
Jack251970: 8%

To learn more about /:\ gitStream - Visit our Docs

1 similar comment
Copy link

gitstream-cm bot commented Jun 9, 2025

🥷 Code experts: Jack251970

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/HotkeyControlDialog.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 23 additions & 23 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
onesounds: 54%
Jack251970: 14%

Flow.Launcher/Resources/Pages/WelcomePage1.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 7 additions & 7 deletions
MAR 2 additions & 2 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 95%
Jack251970: 4%

Flow.Launcher/Resources/Pages/WelcomePage2.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 6 additions & 6 deletions
MAR 1 additions & 1 deletions 1 additions & 2 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 92%
Jack251970: 6%

Flow.Launcher/Resources/Pages/WelcomePage4.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 8 additions & 8 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
onesounds: 93%
Jack251970: 6%

Flow.Launcher/Resources/Pages/WelcomePage5.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 5 additions & 5 deletions
MAR 3 additions & 3 deletions
FEB
JAN

Knowledge based on git-blame:
onesounds: 94%
Jack251970: 4%

Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs

Activity based on git-commit:

onesounds Jack251970
JUN
MAY 15 additions & 4 deletions
APR 355 additions & 225 deletions 64 additions & 137 deletions
MAR 77 additions & 55 deletions
FEB 17 additions & 8 deletions
JAN 33 additions & 3 deletions

Knowledge based on git-blame:
Jack251970: 27%
onesounds: 16%

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Activity based on git-commit:

onesounds Jack251970
JUN 1 additions & 1 deletions
MAY 40 additions & 11 deletions
APR 130 additions & 69 deletions 11 additions & 8 deletions
MAR 43 additions & 62 deletions 44 additions & 20 deletions
FEB 1 additions & 1 deletions
JAN 8 additions & 1 deletions

Knowledge based on git-blame:
onesounds: 62%
Jack251970: 14%

Flow.Launcher/WelcomeWindow.xaml

Activity based on git-commit:

onesounds Jack251970
JUN
MAY
APR 6 additions & 8 deletions
MAR 15 additions & 10 deletions
FEB 1 additions & 4 deletions
JAN

Knowledge based on git-blame:
onesounds: 92%
Jack251970: 8%

To learn more about /:\ gitStream - Visit our Docs

@onesounds onesounds enabled auto-merge June 9, 2025 07:53
@onesounds onesounds merged commit b0c3b71 into Flow-Launcher:dev Jun 9, 2025
7 checks passed
jjw24 pushed a commit that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/ui related to UI, icons, themes, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants