Skip to content

Conversation

stefanroelofs
Copy link
Contributor

@stefanroelofs stefanroelofs commented Jun 10, 2025

Modified Button to use auto width with a minimum width of 100. This change allows the button to grow when keywords do not fit.
image

Modified Button to use auto width with a minimum width of 100. This change allows the button to grow when keywords do not fit.
Copy link
Contributor

coderabbitai bot commented Jun 10, 2025

📝 Walkthrough

Walkthrough

The change updates the Button element in the InstalledPluginDisplayKeyword.xaml file by replacing its fixed width with an auto width and a minimum width constraint. This allows the button to adjust its size dynamically while ensuring it does not become smaller than 100 units.

Changes

File Change Summary
Flow.Launcher/Resources/Controls/InstalledPluginDisplayKeyword.xaml Changed Button Width from fixed (100) to auto with MinWidth 100

Poem

A button once rigid, now free to expand,
With auto-width magic at code’s gentle hand.
No smaller than one hundred, but room now to grow,
In XAML it stretches, as layouts now flow.
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Flow.Launcher/Resources/Controls/InstalledPluginDisplayKeyword.xaml (1)

39-40: Use standard Auto keyword or omit explicit Width
Explicitly setting Width="auto" is non-standard; XAML converters expect "Auto" (or default to Auto when the attribute is absent). Since you’re already specifying MinWidth, it’s clearer to drop the Width property and let the Button auto-size by default.

Apply one of the following diffs:

-                Width="auto"
-                MinWidth="100"
+                <!-- Width removed to allow default auto sizing -->
+                MinWidth="100"

Or, if you want to keep an explicit Auto:

-                Width="auto"
+                Width="Auto"
                 MinWidth="100"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4402c6 and 6d2c7b0.

📒 Files selected for processing (1)
  • Flow.Launcher/Resources/Controls/InstalledPluginDisplayKeyword.xaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Check Spelling

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jack251970 Jack251970 requested a review from onesounds June 10, 2025 08:19
@Jack251970
Copy link
Member

Thank you for the fix! It looks good to me.

@Jack251970
Copy link
Member

@onesounds Should we add maximize width for it?

@Jack251970 Jack251970 added bug Something isn't working kind/ui related to UI, icons, themes, etc labels Jun 10, 2025
@Jack251970 Jack251970 added this to the 1.20.1 milestone Jun 10, 2025
@onesounds
Copy link
Contributor

We probably don't need to set it. If it looks weird, people will likely adjust it themselves.

@Jack251970 Jack251970 merged commit 34f2b7d into Flow-Launcher:dev Jun 10, 2025
6 checks passed
@stefanroelofs
Copy link
Contributor Author

Yeah you don't need maxWidth really. Because settings window itself has variable width.
Very long keywords correctly fit in available space:
image

The action keyword dialog that you open with this button could handle longer keywords better though. I might make a separate PR for that.

jjw24 pushed a commit that referenced this pull request Jun 11, 2025
Update Button width for responsive design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/ui related to UI, icons, themes, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants