-
-
Notifications
You must be signed in to change notification settings - Fork 448
Update Button width for responsive design #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Modified Button to use auto width with a minimum width of 100. This change allows the button to grow when keywords do not fit.
📝 WalkthroughWalkthroughThe change updates the Button element in the InstalledPluginDisplayKeyword.xaml file by replacing its fixed width with an auto width and a minimum width constraint. This allows the button to adjust its size dynamically while ensuring it does not become smaller than 100 units. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Flow.Launcher/Resources/Controls/InstalledPluginDisplayKeyword.xaml (1)
39-40
: Use standard Auto keyword or omit explicit Width
Explicitly setting Width="auto" is non-standard; XAML converters expect "Auto" (or default to Auto when the attribute is absent). Since you’re already specifying MinWidth, it’s clearer to drop the Width property and let the Button auto-size by default.Apply one of the following diffs:
- Width="auto" - MinWidth="100" + <!-- Width removed to allow default auto sizing --> + MinWidth="100"Or, if you want to keep an explicit Auto:
- Width="auto" + Width="Auto" MinWidth="100"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Flow.Launcher/Resources/Controls/InstalledPluginDisplayKeyword.xaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Check Spelling
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Thank you for the fix! It looks good to me. |
@onesounds Should we add maximize width for it? |
We probably don't need to set it. If it looks weird, people will likely adjust it themselves. |
Update Button width for responsive design
Modified Button to use auto width with a minimum width of 100. This change allows the button to grow when keywords do not fit.
