Skip to content

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Jun 11, 2025

Remove AppVeyor on tag release upload:
I don't see a need for this in our release workflow.
This builds new flow artifacts setup exe, portable zip, etc and uploads them again when the GitHub release is published (because publishing creates the tag). This causes the hash to be different to when the artifacts were uploaded during push from dev to master. Different hash causes duplicate deployments on those that rely on the publish action and causes validation failures for package manager projects if they are triggered on the publish release action, prior to the reupload of artifacts from tagging.
image

Change NuGet publish to on master push:
Change to be consistent with the release artifact upload, triggered when pushed to main.

@jjw24 jjw24 added this to the 1.20.1 milestone Jun 11, 2025
@jjw24 jjw24 added the bug Something isn't working label Jun 11, 2025
Copy link

gitstream-cm bot commented Jun 11, 2025

🥷 Code experts: no user but you matched threshold 10

jjw24 has most 👩‍💻 activity in the files.
jjw24 has most 🧠 knowledge in the files.

See details

appveyor.yml

Activity based on git-commit:

jjw24
JUN
MAY 11 additions & 10 deletions
APR
MAR
FEB
JAN

Knowledge based on git-blame:
jjw24: 35%

To learn more about /:\ gitStream - Visit our Docs

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 assigned jjw24 and unassigned JohnTheGr8, taooceros and Jack251970 Jun 11, 2025
@jjw24 jjw24 requested review from JohnTheGr8 and taooceros June 11, 2025 13:12
@jjw24 jjw24 merged commit 222d491 into dev Jun 13, 2025
12 checks passed
@jjw24 jjw24 deleted the remove_ci_tag_trigger branch June 13, 2025 11:27
jjw24 added a commit that referenced this pull request Jun 13, 2025
Remove on tag release upload & change NuGet publish to on master push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants