Remove on tag release upload & change NuGet publish to on master push #3705
+1
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AppVeyor on tag release upload:

I don't see a need for this in our release workflow.
This builds new flow artifacts setup exe, portable zip, etc and uploads them again when the GitHub release is published (because publishing creates the tag). This causes the hash to be different to when the artifacts were uploaded during push from dev to master. Different hash causes duplicate deployments on those that rely on the publish action and causes validation failures for package manager projects if they are triggered on the publish release action, prior to the reupload of artifacts from tagging.
Change NuGet publish to on master push:
Change to be consistent with the release artifact upload, triggered when pushed to main.