Skip to content

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Jun 21, 2025

Rather than trying to work out the milestone, get it from the release PR. This allows for action to run even when multiple milestones set.

Tested:

  • Can retrieve PRs associated with 1.20.2 release.

@jjw24 jjw24 added this to the 2.0.0 milestone Jun 21, 2025
@jjw24 jjw24 requested review from Jack251970 and Copilot June 21, 2025 11:47
@jjw24 jjw24 added bug Something isn't working CI/CD labels Jun 21, 2025
@jjw24 jjw24 removed the request for review from Jack251970 June 21, 2025 11:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub workflow for release PRs to automatically retrieve the milestone number from the release PR instead of calculating it from the repository milestones.

  • Removed milestone API calls and related logic from get_github_prs.
  • Added an optional milestone_number parameter to get_prs to filter PRs by the milestone from the release PR.
  • Updated logging and assignee filtering to reflect these changes.

Co-authored-by: Copilot <[email protected]>
@jjw24 jjw24 marked this pull request as ready for review June 21, 2025 11:54
Copy link

gitstream-cm bot commented Jun 21, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@jjw24 jjw24 enabled auto-merge (squash) June 21, 2025 11:55
@jjw24 jjw24 marked this pull request as draft June 21, 2025 11:56
auto-merge was automatically disabled June 21, 2025 11:56

Pull request was converted to draft

@jjw24 jjw24 marked this pull request as ready for review July 13, 2025 10:42
@jjw24 jjw24 enabled auto-merge July 13, 2025 10:42
@jjw24 jjw24 merged commit dd1f66e into dev Jul 13, 2025
14 checks passed
@jjw24 jjw24 deleted the release_workflow_milestone_from_pr branch July 13, 2025 11:10
jjw24 added a commit that referenced this pull request Jul 13, 2025
…e_from_pr

release_pr GitHub workflow automatically get milestone from release PR
TBM13 pushed a commit to TBM13/Flow.Launcher that referenced this pull request Jul 14, 2025
…flow_milestone_from_pr

release_pr GitHub workflow automatically get milestone from release PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants