Fix Plugin Uninstallation Issue

[Jack251970]

In

Flow.Launcher/Flow.Launcher/PublicAPIInstance.cs

Lines 575 to 576 in e965b56

	public Task UninstallPluginAsync(PluginMetadata pluginMetadata, bool removePluginSettings = false) =>
	PluginManager.UninstallPluginAsync(pluginMetadata, removePluginSettings);

we only pass removePluginSettings parameter.

But in

Flow.Launcher/Flow.Launcher.Core/Plugin/PluginManager.cs

Lines 555 to 558 in e965b56

	public static async Task UninstallPluginAsync(PluginMetadata plugin, bool removePluginFromSettings = true, bool removePluginSettings = false)
	{
	await UninstallPluginAsync(plugin, removePluginFromSettings, removePluginSettings, true);
	}

we have accepted four parameters and removePluginSettings parameter is passed to removePluginFromSettings parameter which can cause possible issues

[Copilot]

Pull Request Overview

This PR aims to fix the plugin uninstallation issue by removing the redundant external parameter "removePluginFromSettings" and ensuring that only the "removePluginSettings" parameter is exposed.

• Removes the "removePluginFromSettings" parameter from the public API
• Hardcodes "removePluginFromSettings" to true in the internal call to maintain consistent behavior

Comments suppressed due to low confidence (1)

Flow.Launcher.Core/Plugin/PluginManager.cs:557

• [nitpick] Since the parameter 'removePluginFromSettings' is now hardcoded to true, please ensure that this behavior is intentional and document the reasoning. If future changes require flexibility, consider refactoring to allow external configuration.

            await UninstallPluginAsync(plugin, removePluginFromSettings: true, removePluginSettings: removePluginSettings, checkModified: true);

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, VictoriousRaptor have most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/Plugin/PluginManager.cs

Activity based on git-commit:

	Jack251970
JUN
MAY	89 additions & 25 deletions
APR	73 additions & 68 deletions
MAR	42 additions & 37 deletions
FEB	276 additions & 198 deletions
JAN	5 additions & 5 deletions

Knowledge based on git-blame:
Jack251970: 33%
VictoriousRaptor: 17%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The method signature of UninstallPluginAsync in PluginManager was modified to remove the removePluginFromSettings parameter, which is now hardcoded to true within the method. The public API is simplified, taking only PluginMetadata plugin and an optional removePluginSettings parameter.

Changes

File(s)	Change Summary
Flow.Launcher.Core/Plugin/PluginManager.cs	Updated UninstallPluginAsync method signature, removed removePluginFromSettings parameter, and hardcoded its value internally.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant PluginManager

    Caller->>PluginManager: UninstallPluginAsync(plugin, removePluginSettings)
    PluginManager->>PluginManager: UninstallPluginAsync(plugin, removePluginFromSettings: true, removePluginSettings, checkModified: true)

Loading

Suggested reviewers

• jjw24
• taooceros

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e965b56 and 3fc0abf.

📒 Files selected for processing (1)

• Flow.Launcher.Core/Plugin/PluginManager.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: build

🔇 Additional comments (1)

Flow.Launcher.Core/Plugin/PluginManager.cs (1)

555-558: Public API signature change is safe: no breaking callers detected

The UninstallPluginAsync(PluginMetadata, bool removePluginSettings = false) overload now aligns with the IPublicAPI interface and all existing call sites:

• Flow.Launcher/PublicAPIInstance.cs delegates to the new two-parameter overload
• Plugins/Flow.Launcher.Plugin.PluginsManager invokes Context.API.UninstallPluginAsync(plugin, removePluginSettings)

All internal and external callers have been updated accordingly, and the hardcoded removePluginFromSettings: true mapping is correct. No further action required.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Jack251970]

@jjw24 This PR can affect #3572's behaviour, so please merge it before checking that PR