Fix Home Page Update Issue

[Jack251970]

Changes

• When we edit these two options, home page should be updated now
  • Change hotkey & modifier binding to one way binding so that the visibility of result hotkey and hotkey modifier string will be changed once the settings are updated.

[gitstream-cm]

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

Activity based on git-commit:

	Jack251970	onesounds
JUL
JUN	4 additions & 2 deletions
MAY	86 additions & 30 deletions	5 additions & 3 deletions
APR	34 additions & 83 deletions	104 additions & 38 deletions
MAR	142 additions & 94 deletions	10 additions & 0 deletions
FEB	10 additions & 4 deletions

Knowledge based on git-blame:
Jack251970: 31%
onesounds: 20%

Flow.Launcher/ResultListBox.xaml

Activity based on git-commit:

	Jack251970	onesounds
JUL
JUN
MAY
APR	2 additions & 4 deletions	65 additions & 61 deletions
MAR		18 additions & 16 deletions
FEB

Knowledge based on git-blame:
onesounds: 74%

Flow.Launcher/ViewModel/ResultViewModel.cs

Activity based on git-commit:

	Jack251970	onesounds
JUL
JUN
MAY
APR	70 additions & 16 deletions
MAR	47 additions & 50 deletions
FEB

Knowledge based on git-blame:
Jack251970: 31%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes refactor how the OpenResultModifiers and ShowOpenResultHotkey properties are handled in the application's settings, moving change notification logic into the Settings class. The ResultViewModel no longer exposes these properties, and XAML bindings are updated to reference the Settings object directly, using a converter for visibility.

Changes

File(s)	Change Summary
Flow.Launcher.Infrastructure/UserSettings/Settings.cs	Converted OpenResultModifiers and ShowOpenResultHotkey from auto-properties to full properties with change notification (OnPropertyChanged).
Flow.Launcher/ViewModel/ResultViewModel.cs	Removed ShowOpenResultHotkey and OpenResultModifiers properties from the view model.
Flow.Launcher/ResultListBox.xaml	Updated bindings to reference Settings.OpenResultModifiers and Settings.ShowOpenResultHotkey with one-way mode; added BoolToVisibilityConverter resource.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI (ResultListBox)
    participant Settings

    User->>Settings: Change OpenResultModifiers or ShowOpenResultHotkey
    Settings->>UI (ResultListBox): OnPropertyChanged notification
    UI (ResultListBox)->>UI (ResultListBox): Updates UI via binding and BoolToVisibilityConverter

Loading

Possibly related PRs

• Flow-Launcher/Flow.Launcher#3553: Implements change notification for a different property in the Settings class using the same pattern as this PR.

Suggested reviewers

• jjw24

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b16cd14 and 67ec700.

📒 Files selected for processing (2)

• Flow.Launcher/ResultListBox.xaml (3 hunks)
• Flow.Launcher/ViewModel/ResultViewModel.cs (0 hunks)

💤 Files with no reviewable changes (1)

• Flow.Launcher/ViewModel/ResultViewModel.cs

🚧 Files skipped from review as they are similar to previous changes (1)

• Flow.Launcher/ResultListBox.xaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR ensures the home page (results view) updates immediately when changing the result modifier key or toggling the open-result-hotkey visibility.

• Settings properties (OpenResultModifiers, ShowOpenResultHotkey) now raise change notifications
• XAML updated to bind directly to Settings.ShowOpenResultHotkey with a one-way converter
• Main window listens for modifier-key changes to re-query results if on the home page

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
Flow.Launcher/ViewModel/ResultViewModel.cs	Removed the computed ShowOpenResultHotkey property to rely on direct binding
Flow.Launcher/ResultListBox.xaml	Added BoolToVisibilityConverter resource and switched binding to settings
Flow.Launcher/MainWindow.xaml.cs	Added case for Settings.OpenResultModifiers to refresh home page queries
Flow.Launcher.Infrastructure/UserSettings/Settings.cs	Converted two auto-properties into manual properties that fire OnPropertyChanged

Comments suppressed due to low confidence (3)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs:45

• There’s no test covering the OpenResultModifiers change notification and subsequent UI update. Add a unit or integration test to confirm modifying this property triggers the expected re-query behavior on the home page.

        public string OpenResultModifiers

Flow.Launcher/ResultListBox.xaml:39

• [nitpick] You now have two different visibility converters (BoolToVisibilityConverter and OpenResultHotkeyVisibilityConverter). Consider consolidating into one to reduce confusion and duplicated logic.

        <converter:BoolToVisibilityConverter x:Key="BoolToVisibilityConverter" />