Skip to content

Fix the issue where UWP changes are not monitored #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

Fix the issue where UWP changes are not monitored #3821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb946b7
Fix the issue that UWP changes that can't be monitored (#2345)
VictoriousRaptor Jul 13, 2025
2eeb097
Use lazy init after version check
VictoriousRaptor Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,12 @@
var namespaceManager = new XmlNamespaceManager(xmlDoc.NameTable);
namespaceManager.AddNamespace("d",
"http://schemas.microsoft.com/appx/manifest/foundation/windows10"); // still need a name
namespaceManager.AddNamespace("rescap",

Check warning on line 89 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`rescap` is not a recognized word. (unrecognized-spelling)
"http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities");
namespaceManager.AddNamespace("uap10", "http://schemas.microsoft.com/appx/manifest/uap/windows10/10");

Check warning on line 91 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`uap` is not a recognized word. (unrecognized-spelling)

Check warning on line 91 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`uap` is not a recognized word. (unrecognized-spelling)

var allowElevationNode =
xmlRoot.SelectSingleNode("//rescap:Capability[@Name='allowElevation']", namespaceManager);

Check warning on line 94 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`rescap` is not a recognized word. (unrecognized-spelling)
bool packageCanElevate = allowElevationNode != null;

var appsNode = xmlRoot.SelectSingleNode("d:Applications", namespaceManager);
Expand Down Expand Up @@ -290,12 +290,13 @@
}

private static readonly Channel<byte> PackageChangeChannel = Channel.CreateBounded<byte>(1);
private static PackageCatalog? catalog;

Check warning on line 293 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 293 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

public static async Task WatchPackageChangeAsync()
{
if (Environment.OSVersion.Version.Major >= 10)
{
var catalog = PackageCatalog.OpenForCurrentUser();
catalog ??= PackageCatalog.OpenForCurrentUser();
catalog.PackageInstalling += (_, args) =>
{
if (args.IsComplete)
Expand Down Expand Up @@ -457,7 +458,7 @@
_ = Task.Run(() => Launch(shouldRunElevated)).ConfigureAwait(false);
if (elevated && !shouldRunElevated)
{
var title = api.GetTranslation("flowlauncher_plugin_program_disable_dlgtitle_error");

Check warning on line 461 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`dlgtitle` is not a recognized word. (unrecognized-spelling)
var message =
api.GetTranslation(
"flowlauncher_plugin_program_run_as_administrator_not_supported_message");
Expand Down Expand Up @@ -523,7 +524,7 @@
// and https://learn.microsoft.com/uwp/schemas/appxpackage/uapmanifestschema/element-application#attributes

return appNode?.Attributes["EntryPoint"]?.Value == "Windows.FullTrustApplication" ||
appNode?.Attributes["uap10:TrustLevel"]?.Value == "mediumIL";

Check warning on line 527 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`uap` is not a recognized word. (unrecognized-spelling)
}

internal string LogoPathFromUri(string uri, (int, int) desiredSize)
Expand Down Expand Up @@ -584,7 +585,7 @@

// Currently we don't care which one to choose
// Just ignore all qualifiers
// select like logo.[xxx_yyy].png

Check warning on line 588 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`yyy` is not a recognized word. (unrecognized-spelling)
// https://learn.microsoft.com/en-us/windows/uwp/app-resources/tailor-resources-lang-scale-contrast

// todo select from file name like pt run
Expand Down Expand Up @@ -702,7 +703,7 @@
// var bitmap = new RenderTargetBitmap(
// Convert.ToInt32(width), Convert.ToInt32(height),
// dpiScale100, dpiScale100,
// PixelFormats.Pbgra32

Check warning on line 706 in Plugins/Flow.Launcher.Plugin.Program/Programs/UWPPackage.cs

View workflow job for this annotation

GitHub Actions / Check Spelling 

`Pbgra` is not a recognized word. (unrecognized-spelling)
// );
// bitmap.Render(visual);
// return bitmap;
Expand Down
Loading