Reload on all settings change

[Jack251970]

Follow on with #3829

Change reload logic

[gitstream-cm]

🥷 Code experts: VictoriousRaptor

VictoriousRaptor, Jack251970 have most 👩‍💻 activity in the files.
Jack251970, VictoriousRaptor have most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/PinyinAlphabet.cs

Activity based on git-commit:

	VictoriousRaptor	Jack251970
JUL	94 additions & 59 deletions	1 additions & 4 deletions
JUN	113 additions & 170 deletions
MAY
APR		43 additions & 41 deletions
MAR
FEB

Knowledge based on git-blame:
VictoriousRaptor: 84%
Jack251970: 7%

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

Activity based on git-commit:

	VictoriousRaptor	Jack251970
JUL	21 additions & 6 deletions	31 additions & 3 deletions
JUN	28 additions & 2 deletions	4 additions & 2 deletions
MAY		86 additions & 30 deletions
APR		34 additions & 83 deletions
MAR	1 additions & 1 deletions	142 additions & 94 deletions
FEB		10 additions & 4 deletions

Knowledge based on git-blame:
Jack251970: 33%
VictoriousRaptor: 18%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes refactor the event handler logic for Pinyin-related settings in the infrastructure layer, introducing more granular conditional checks before reloading settings. Additionally, the ShouldUsePinyin property in user settings is modified to include change notification and a new default value.

Changes

File(s)	Change Summary
Flow.Launcher.Infrastructure/PinyinAlphabet.cs	Refactored event handler for settings changes to use a switch statement and conditional checks before reloading.
Flow.Launcher.Infrastructure/UserSettings/Settings.cs	Changed ShouldUsePinyin property to use a backing field, added change notification, and set default to true.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Settings
    participant PinyinAlphabet

    User->>Settings: Change property (ShouldUsePinyin/UseDoublePinyin/DoublePinyinSchema)
    Settings-->>PinyinAlphabet: PropertyChanged event
    PinyinAlphabet->>PinyinAlphabet: switch(propertyName)
    alt ShouldUsePinyin && ShouldUsePinyin == true
        PinyinAlphabet->>PinyinAlphabet: Reload()
    else UseDoublePinyin/DoublePinyinSchema && UseDoublePinyin == true
        PinyinAlphabet->>PinyinAlphabet: Reload()
    end

Loading

Possibly related PRs

• Double pinyin query #2427: Refactors PinyinAlphabet event handler to conditionally reload settings based on new properties, directly related to these changes.

Suggested labels

enhancement

Suggested reviewers

• taooceros

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb81f71 and 8c56c0b.

📒 Files selected for processing (2)

• Flow.Launcher.Infrastructure/PinyinAlphabet.cs (1 hunks)
• Flow.Launcher.Infrastructure/UserSettings/Settings.cs (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

Flow.Launcher.Infrastructure/PinyinAlphabet.cs (1)

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3791
File: Flow.Launcher.Core/Plugin/PluginManager.cs:293-295
Timestamp: 2025-07-01T05:46:13.251Z
Learning: In Flow.Launcher.Core/Plugin/PluginManager.cs, when checking if a plugin is modified within the PluginManager class itself, prefer using the internal static PluginModified(string id) method directly rather than going through API.PluginModified() for better performance and architectural design.

🧬 Code Graph Analysis (1)

Flow.Launcher.Infrastructure/PinyinAlphabet.cs (1)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs (1)

• Settings (16-597)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: build

🔇 Additional comments (2)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs (1)

331-343: Verify backward-compatibility of ShouldUsePinyin default change

The backing field _useAlphabet now defaults to true (previously false), which will impact only first‐time installations. To ensure existing users aren’t affected:

• In Flow.Launcher.Infrastructure/UserSettings/Settings.cs, confirm that the Load() method applies persisted values before the default is ever used.
• Double-check that no unit tests or documentation assume the old false default. (A ripgrep search returned no matches.)
• If this change is intentional, consider adding migration logic for edge cases or documenting it in the release notes.

Flow.Launcher.Infrastructure/PinyinAlphabet.cs (1)

28-44: Excellent refactoring with performance optimization.

The switch statement improves readability and maintainability. The conditional checks before calling Reload() are a smart optimization:

• For ShouldUsePinyin: Only reload when pinyin functionality is enabled
• For UseDoublePinyin and DoublePinyinSchema: Only reload when double pinyin is enabled

This prevents unnecessary reloads when features are disabled, improving performance.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[VictoriousRaptor]

Nice catch!