Update wording and fix spell check #3832
Conversation
VictoriousRaptor
force-pushed
the
tweak-double-pin-pane
branch
from
65f027b to
f3bca63
Compare
VictoriousRaptor
added
Dev branch only
This comment has been minimized.
This comment has been minimized.
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThis update modifies the tooltip text for the "Use Double Pinyin" setting in the English localization file, updates spelling workflow configuration to use a fixed action version, and adjusts spelling allowlist, exception, and pattern files by removing, adding, or replacing specific entries related to Pinyin input methods and Portuguese. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Localization
User->>UI: Hover over "Use Double Pinyin" setting
UI->>Localization: Fetch updated tooltip text
Localization-->>UI: Return new tooltip string
UI-->>User: Display updated tooltip
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Flow.Launcher/Languages/en.xaml (1)
109-109: Consider tightening the sentence for consistency with other tooltipsMost nearby tooltips start with an action verb (“Allows…”, “Temporarily change…”, “Adds a short delay…”).
To keep style uniform, prefer:-<system:String x:Key="ShouldUseDoublePinyinToolTip">Use Double Pinyin instead of Full Pinyin to search.</system:String> +<system:String x:Key="ShouldUseDoublePinyinToolTip">Search using Double Pinyin instead of Full Pinyin.</system:String>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Flow.Launcher/Languages/en.xaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
🪛 GitHub Actions: Check Spelling
Flow.Launcher/Languages/en.xaml
[warning] 111-111: Spell check warning: Xiao is not a recognized word. (unrecognized-spelling)
[warning] 113-113: Spell check warning: Ruan is not a recognized word. (unrecognized-spelling)
[warning] 114-114: Spell check warning: Neng is not a recognized word. (unrecognized-spelling)
[warning] 114-114: Spell check warning: Zhi is not a recognized word. (unrecognized-spelling)
[warning] 115-115: Spell check warning: Guang is not a recognized word. (unrecognized-spelling)
[warning] 116-116: Spell check warning: Jia is not a recognized word. (unrecognized-spelling)
[warning] 116-116: Spell check warning: Jia is not a recognized word. (unrecognized-spelling)
[warning] 116-116: Spell check warning: Jia is not a recognized word. (unrecognized-spelling)
[warning] 117-117: Spell check warning: Jian is not a recognized word. (unrecognized-spelling)
[warning] 119-119: Spell check warning: Xiao is not a recognized word. (unrecognized-spelling)
[warning] 119-119: Spell check warning: Xiao is not a recognized word. (unrecognized-spelling)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: gitStream workflow automation
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: build
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Do we need to fix the spelling raised by the check as well? |
They are not well formed English words so can be rejected by built-in checks. Use regex as a workaround.
|
|
It looks good for me, but I am just undecided. Please wait for others to approve it |
|
🥷 Code experts: jjw24 VictoriousRaptor, jjw24 have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
jjw24
removed
bug
Update wording and fix spell check