Improve Sys plugin & add APIs for getting user data and log locations #3848
Conversation
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 Walkthrough""" WalkthroughTwo new methods for retrieving the data and log directories were added to the public API interface and its implementation. The system plugin was updated to use these API methods for accessing directories, improved error localization, and adjusted UI behavior for the settings dialog. Unused references and directives were removed, and a documentation URL constant was introduced. Changes
Sequence Diagram(s)sequenceDiagram
participant Plugin as System Plugin
participant API as PublicAPIInstance
participant DataLoc as DataLocation
Plugin->>API: GetDataDirectory()
API->>DataLoc: DataDirectory()
DataLoc-->>API: data directory path
API-->>Plugin: data directory path
Plugin->>API: GetLogDirectory()
API->>DataLoc: VersionLogDirectory
DataLoc-->>API: log directory path
API-->>Plugin: log directory path
Estimated code review effort2 (10–30 minutes) Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Sys plugin to use new API methods instead of direct dependencies, improves internationalization, and enhances the user experience. The main purpose is to decouple the plugin from infrastructure dependencies while providing better localization support.
- Replaces direct
DataLocationusage with new API methodsGetDataDirectory()andGetLogDirectory() - Adds internationalization support for error messages in recycle bin operations
- Improves settings dialog display by hiding the main window before opening it
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Main.cs | Refactored to use new API methods, added i18n for error messages, and improved settings dialog UX |
| en.xaml | Added translation keys for error dialog title and recycle bin failure message |
| Flow.Launcher.Plugin.Sys.csproj | Removed Infrastructure project reference to reduce coupling |
| PublicAPIInstance.cs | Implemented new API methods for accessing data and log directories |
| IPublicAPI.cs | Added interface definitions for the new directory access methods |
Co-authored-by: Copilot <[email protected]>
jjw24
changed the title
…mprovement Improve Sys plugin
CHANGES
string GetDataDirectory();andstring GetLogDirectory();to drop Flow.Launcher.Infrastructure project reference in Sys pluginTEST