Remove unnecessary runtime files #3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThe project file was updated to include two new MSBuild targets that automatically remove unnecessary runtime-specific directories from the build and publish outputs after the respective processes complete. This cleanup targets directories for various non-required platforms and architectures. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant MSBuild
participant FileSystem
Developer->>MSBuild: Build or Publish project
MSBuild->>MSBuild: Execute Build/Publish
MSBuild->>MSBuild: Run RemoveUnnecessaryRuntimesAfterBuild/AfterPublish
MSBuild->>FileSystem: Delete unnecessary runtime directories
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Flow.Launcher/Flow.Launcher.csproj (1)
63-82: Duplication & maintainability: share logic with the build target
RemoveUnnecessaryRuntimesAfterPublishrepeats the entire directory list. Any future tweak must be made in two places, risking drift.Consider:
- Define the list once:
<PropertyGroup> <RuntimeDirsToRemove> browser-wasm; linux-arm; …; osx-x64 </RuntimeDirsToRemove> </PropertyGroup>
- Use a single helper target that receives either
$(OutputPath)or$(PublishDir)as a parameter and runs the guardedRemoveDirlogic shown above, then call that helper from bothAfterTargets="Build"andAfterTargets="Publish".This eliminates duplication and centralises the risky path list.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Flow.Launcher/Flow.Launcher.csproj(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
📚 Learning: in the flow launcher project, the version number in the `flow.launcher.csproj` file is dynamically u...
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
Applied to files:
Flow.Launcher/Flow.Launcher.csproj
📚 Learning: when implementing collection item removal operations in flow launcher, always handle index boundarie...
Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3561
File: Flow.Launcher/ViewModel/SelectBrowserViewModel.cs:53-58
Timestamp: 2025-05-21T10:37:07.696Z
Learning: When implementing collection item removal operations in Flow Launcher, always handle index boundaries carefully. After removing an item from a collection, ensure the updated index remains within valid bounds (>= 0 and < collection.Count) to prevent IndexOutOfRangeExceptions, especially when decrementing indexes.
Applied to files:
Flow.Launcher/Flow.Launcher.csproj
📚 Learning: the `$flowversion` parameter in the `post_build.ps1` script is intentionally left unset for dynamic ...
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Scripts/post_build.ps1:2-5
Timestamp: 2024-10-12T22:14:51.524Z
Learning: The `$flowVersion` parameter in the `post_build.ps1` script is intentionally left unset for dynamic assignment during script execution. The script contains logic to handle cases where this parameter remains unset.
Applied to files:
Flow.Launcher/Flow.Launcher.csproj
📚 Learning: in flow launcher, the updatepluginmanifestasync method in pluginsmanifest.cs already has comprehensi...
Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.
Applied to files:
Flow.Launcher/Flow.Launcher.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: gitStream workflow automation
- GitHub Check: gitStream.cm
- GitHub Check: build
Jack251970
changed the title
This reverts commit 9f5d578.
Jack251970
changed the title
|
🥷 Code experts: no user but you matched threshold 10 Jack251970, VictoriousRaptor have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Are these unnecessary files introduced by the .Net upgrade? |
jjw24
reviewed
Aug 7, 2025
Not sure. I noticed this when I was checking another package size issue. |
As far as I know, one another way is to set specific |
|
Setting |
taooceros
approved these changes
Aug 7, 2025
I remember that this is problematic |
jjw24
added
bug
TBM13
pushed a commit
to TBM13/Flow.Launcher
that referenced
this pull request
Aug 13, 2025
…me_files Remove unnecessary runtime files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove unnecessary runtime files for Flow.Launcher
Size Change
Original:
After: