Test Nuget Package Restore #3924
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,9 +25,9 @@ | |
| }, | ||
| "Fody": { | ||
| "type": "Direct", | ||
| "requested": "[6.5.5, )", | ||
| "resolved": "6.5.5", | ||
| "contentHash": "Krca41L/PDva1VsmDec5n52cQZxQAQp/bsHdzsNi8iLLI0lqKL94fNIkNaC8tVolUkCyWsbzvxfxJCeD2789fA==" | ||
| }, | ||
| "InputSimulator": { | ||
| "type": "Direct", | ||
|
|
@@ -93,11 +93,11 @@ | |
| }, | ||
| "PropertyChanged.Fody": { | ||
| "type": "Direct", | ||
| "requested": "[3.4.0, )", | ||
| "resolved": "3.4.0", | ||
| "contentHash": "IAZyq0uolKo2WYm4mjx+q7A8fSGFT0x2e1s3y+ODn4JI0kqTDoo9GF2tdaypUzRFJZfdMxfC5HZW9QzdJLtOnA==", | ||
| "dependencies": { | ||
| "Fody": "6.5.1" | ||
| } | ||
| }, | ||
| "SharpVectors.Wpf": { | ||
|
|
@@ -108,18 +108,18 @@ | |
| }, | ||
| "System.Drawing.Common": { | ||
| "type": "Direct", | ||
| "requested": "[7.0.0, )", | ||
| "resolved": "7.0.0", | ||
| "contentHash": "KIX+oBU38pxkKPxvLcLfIkOV5Ien8ReN78wro7OF5/erwcmortzeFx+iBswlh2Vz6gVne0khocQudGwaO1Ey6A==", | ||
| "dependencies": { | ||
| "Microsoft.Win32.SystemEvents": "7.0.0" | ||
| } | ||
| }, | ||
|
Comment on lines
110
to
117
There was a problem hiding this comment. 🛠️ Refactor suggestion SystemEvents version is only transitive. Consider direct pin. System.Drawing.Common pulls Microsoft.Win32.SystemEvents 7.0.0 transitively. Make it explicit in the project to ensure future transitive updates don’t regress #3846. 🤖 Prompt for AI Agents |
||
| "ToolGood.Words.Pinyin": { | ||
| "type": "Direct", | ||
| "requested": "[3.0.1.4, )", | ||
| "resolved": "3.0.1.4", | ||
| "contentHash": "uQo97618y9yzLDxrnehPN+/tuiOlk5BqieEdwctHZOAS9miMXnHKgMFYVw8CSGXRglyTYXlrW7qtUlU7Fje5Ew==" | ||
| }, | ||
| "JetBrains.Annotations": { | ||
| "type": "Transitive", | ||
|
|
@@ -156,8 +156,8 @@ | |
| }, | ||
| "Microsoft.Win32.SystemEvents": { | ||
| "type": "Transitive", | ||
| "resolved": "7.0.0", | ||
| "contentHash": "2nXPrhdAyAzir0gLl8Yy8S5Mnm/uBSQQA7jEsILOS1MTyS7DbmV1NgViMtvV1sfCD1ebITpNwb1NIinKeJgUVQ==" | ||
| }, | ||
| "Microsoft.Windows.SDK.Win32Docs": { | ||
| "type": "Transitive", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Pin Microsoft.Win32.SystemEvents explicitly instead of broad downgrades.
If #3846 is due to SystemEvents regressions, rely on an explicit, direct pin rather than downgrading unrelated packages (StreamJsonRpc, FSharp.Core, etc.). This makes intent clear and prevents future transitive bumps from reintroducing the bug.
Apply:
<ItemGroup> <PackageReference Include="Droplex" Version="1.7.0" /> <PackageReference Include="FSharp.Core" Version="9.0.201" /> <PackageReference Include="Meziantou.Framework.Win32.Jobs" Version="3.4.0" /> <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.1" /> <PackageReference Include="SemanticVersioning" Version="3.0.0" /> <PackageReference Include="squirrel.windows" Version="1.5.2" NoWarn="NU1701" /> <PackageReference Include="StreamJsonRpc" Version="2.21.10" /> + <PackageReference Include="Microsoft.Win32.SystemEvents" Version="7.0.0" /> </ItemGroup>Follow-up: after pinning, consider reverting unrelated downgrades if they weren’t required.
🏁 Script executed:
#!/bin/bash git diff HEAD~1 -- Flow.Launcher.Core/Flow.Launcher.Core.csprojLength of output: 1279
🏁 Script executed:
Length of output: 3791
🏁 Script executed:
Length of output: 5926
Pin Microsoft.Win32.SystemEvents explicitly to 7.0.0.
Add this direct reference in Flow.Launcher.Core/Flow.Launcher.Core.csproj to lock the transitive SystemEvents version instead of downgrading unrelated packages:
<ItemGroup> <PackageReference Include="Droplex" Version="1.7.0" /> <PackageReference Include="FSharp.Core" Version="9.0.201" /> <PackageReference Include="Meziantou.Framework.Win32.Jobs" Version="3.4.0" /> <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.1" /> <PackageReference Include="SemanticVersioning" Version="3.0.0" /> <PackageReference Include="squirrel.windows" Version="1.5.2" NoWarn="NU1701" /> <PackageReference Include="StreamJsonRpc" Version="2.21.10" /> + <PackageReference Include="Microsoft.Win32.SystemEvents" Version="7.0.0" /> </ItemGroup>This makes the intent clear and prevents future transitive bumps (via System.Drawing.Common) from reintroducing the issue.
🤖 Prompt for AI Agents