Switch plugins manifest file download URL to be from main branch #3933
Conversation
|
🥷 Code experts: Jack251970, taooceros Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
jjw24
requested review from
Garulf,
JohnTheGr8,
Yusyuriv,
onesounds,
VictoriousRaptor,
deefrawley,
kubalav,
taooceros,
Jack251970,
z1nc0r3 and
cibere
📝 WalkthroughWalkthroughUpdated plugin manifest source URLs in PluginsManifest initialization from the plugin_api_v2 branch to the main branch. No logic changes to fetching, filtering, caching, or synchronization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs (1)
74-77: Enforce MinimumAppVersion ≥ 2.0.0 for all plugins in main/plugins.json
20 plugins are missingMinimumAppVersion(Google Search Plus, Plugin Runner, Dictionary, SpotifyPremium, ClipboardHistory, Window Walker, Everything, Colors, Currency Converter, IP Address, Flow.Plugin.UrlEncode, Putty, LibreTranslate, Todoist, Todos, Direct Translate, GitHub, isPrime, RollDice, Fancy Emoji). Without these fields, older Flow releases will install .NET 9 plugins and fail at runtime. Add"MinimumAppVersion": "2.0.0"to each entry inmain/plugins.json.
🧹 Nitpick comments (1)
Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs (1)
15-19: Factor branch/repo into constants to avoid multi-point edits next time.Prevents future churn if the branch changes again; also improves readability.
Apply this diff:
- private static readonly CommunityPluginStore mainPluginStore = - new("https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/main/plugins.json", - "https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@main/plugins.json", - "https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@main/plugins.json", - "https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@main/plugins.json"); + private const string ManifestBranch = "main"; + private const string ManifestRepo = "Flow-Launcher/Flow.Launcher.PluginsManifest"; + private static readonly CommunityPluginStore mainPluginStore = + new($"https://raw.githubusercontent.com/{ManifestRepo}/{ManifestBranch}/plugins.json", + $"https://fastly.jsdelivr.net/gh/{ManifestRepo}@{ManifestBranch}/plugins.json", + $"https://gcore.jsdelivr.net/gh/{ManifestRepo}@{ManifestBranch}/plugins.json", + $"https://cdn.jsdelivr.net/gh/{ManifestRepo}@{ManifestBranch}/plugins.json");
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-07-06T12:21:37.947Z
Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.
Applied to files:
Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs
📚 Learning: 2025-07-01T05:46:13.251Z
Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3791
File: Flow.Launcher.Core/Plugin/PluginManager.cs:293-295
Timestamp: 2025-07-01T05:46:13.251Z
Learning: In Flow.Launcher.Core/Plugin/PluginManager.cs, when checking if a plugin is modified within the PluginManager class itself, prefer using the internal static PluginModified(string id) method directly rather than going through API.PluginModified() for better performance and architectural design.
Applied to files:
Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: gitStream.cm
- GitHub Check: build
🔇 Additional comments (1)
Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs (1)
16-19: URLs switched to main — LGTM.This aligns with the v2.0.0/.NET 9 rollout intent and keeps CDN fallbacks intact.
For v2.0.0 flow, we switch the manifest file plugins.json back to the main branch. This is due to .NET 9 upgrade, we need to prevent older flow versions from updating to plugins in this release. Default plugins are now on .NET 9 and will not work with older versions.
Follows on from #3286