Skip to content

Handle MinimumAppVersion parse fail and reorder last manifest fetch date #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

Handle MinimumAppVersion parse fail and reorder last manifest fetch date #3943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b0b60
handle version parse fail and reorder last manifest fetch date
jjw24 Sep 4, 2025
5d297c1
update to log info for plugin version requirement failure
jjw24 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions Flow.Launcher.Core/ExternalPlugins/PluginsManifest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ public static async Task<bool> UpdateManifestAsync(bool usePrimaryUrlOnly = fals
if (results.Count == 0)
return false;

lastFetchedAt = DateTime.Now;

var updatedPluginResults = new List<UserPlugin>();
var appVersion = SemanticVersioning.Version.Parse(Constant.Version);

Expand All @@ -56,6 +54,8 @@ public static async Task<bool> UpdateManifestAsync(bool usePrimaryUrlOnly = fals

UserPlugins = updatedPluginResults;

lastFetchedAt = DateTime.Now;

return true;
}
}
Expand All @@ -73,9 +73,21 @@ public static async Task<bool> UpdateManifestAsync(bool usePrimaryUrlOnly = fals

private static bool IsMinimumAppVersionSatisfied(UserPlugin plugin, SemanticVersioning.Version appVersion)
{
if (string.IsNullOrEmpty(plugin.MinimumAppVersion) || appVersion >= SemanticVersioning.Version.Parse(plugin.MinimumAppVersion))
if (string.IsNullOrEmpty(plugin.MinimumAppVersion))
return true;

try
{
if (appVersion >= SemanticVersioning.Version.Parse(plugin.MinimumAppVersion))
return true;
}
catch (Exception e)
{
API.LogException(ClassName, $"Failed to parse the minimum app version {plugin.MinimumAppVersion} for plugin {plugin.Name}. "
+ "Plugin excluded from manifest", e);
return false;
}

API.LogDebug(ClassName, $"Plugin {plugin.Name} requires minimum Flow Launcher version {plugin.MinimumAppVersion}, "
+ $"but current version is {Constant.Version}. Plugin excluded from manifest.");

Expand Down
Loading