Skip to content

Catch scary exception, print friendly log #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2025
Merged

Catch scary exception, print friendly log #3975

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e63c4f3
Catch scary exception, print friendly log
dcog989 Sep 13, 2025
6eeef62
Merge branch 'dev' into CommunityPluginSource-logging-refined
dcog989 Sep 13, 2025
f3998a1
explicit exception logging
dcog989 Sep 13, 2025
08a571f
Merge branch 'CommunityPluginSource-logging-refined' of https://githu…
dcog989 Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,17 @@ public async Task<List<UserPlugin>> FetchAsync(CancellationToken token)
return null;
}
}
catch (OperationCanceledException) when (token.IsCancellationRequested)
{
API.LogInfo(ClassName, $"Fetching from {ManifestFileUrl} was cancelled by caller.");
return null;
}
catch (TaskCanceledException)
{
// Likely an HttpClient timeout or external cancellation not requested by our token
API.LogWarn(ClassName, $"Fetching from {ManifestFileUrl} timed out.");
return null;
}
catch (Exception e)
{
if (e is HttpRequestException or WebException or SocketException || e.InnerException is TimeoutException)
Expand Down
Loading