-
-
Notifications
You must be signed in to change notification settings - Fork 442
Code cleanup & Use Flow.Launcher.Localization to improve code quality #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
920162f
Use Flow.Launcher.Localization to improve code quality
Jack251970 343b65c
Merge dev branch
Jack251970 62abf67
Code cleanup
Jack251970 6b5e20b
Improve code quality
Jack251970 071914e
Improve code quality
Jack251970 479d665
Use internal static Context & Improve code quality
Jack251970 a3ee3ec
Use Flow.Launcher.Localization to improve code quality
Jack251970 26ec51c
Code cleanup
Jack251970 e286143
Use Flow.Launcher.Localization to improve code quality
Jack251970 5c1c6e9
Improve code quality
Jack251970 a9364cb
Improve code quality
Jack251970 41200b8
Use Flow.Launcher.Localization to improve code quality
Jack251970 2234ed1
Merge branch 'dev' into flow_launcher_localization
Jack251970 d20dacc
Fix logic issue
Jack251970 163af5c
Fix the variable name typo
Jack251970 dad5f5a
Fix redundant boolean cast and ensure consistent default value handling
Jack251970 af1d11a
Use Flow.Launcher.Localization to improve code quality
Jack251970 017e1bd
Revert namespace styles
Jack251970 979f75e
Fix indent format
Jack251970 d73dedc
Revert namespace style
Jack251970 0fbfad0
Fix indent format
Jack251970 e4b8f12
Fix namespace style
Jack251970 087a169
Fix indent format
Jack251970 14a0a17
Fix indent format
Jack251970 742caf2
Merge branch 'dev' into flow_launcher_localization
VictoriousRaptor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 12 additions & 13 deletions
25
Plugins/Flow.Launcher.Plugin.Calculator/DecimalSeparator.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,16 @@ | ||
| using Flow.Launcher.Localization.Attributes; | ||
|
|
||
| namespace Flow.Launcher.Plugin.Calculator | ||
| namespace Flow.Launcher.Plugin.Calculator; | ||
|
|
||
| [EnumLocalize] | ||
| public enum DecimalSeparator | ||
| { | ||
| [EnumLocalize] | ||
| public enum DecimalSeparator | ||
| { | ||
| [EnumLocalizeKey(nameof(Localize.flowlauncher_plugin_calculator_decimal_separator_use_system_locale))] | ||
| UseSystemLocale, | ||
|
|
||
| [EnumLocalizeKey(nameof(Localize.flowlauncher_plugin_calculator_decimal_separator_dot))] | ||
| Dot, | ||
|
|
||
| [EnumLocalizeKey(nameof(Localize.flowlauncher_plugin_calculator_decimal_separator_comma))] | ||
| Comma | ||
| } | ||
| [EnumLocalizeKey(nameof(Localize.flowlauncher_plugin_calculator_decimal_separator_use_system_locale))] | ||
| UseSystemLocale, | ||
|
|
||
| [EnumLocalizeKey(nameof(Localize.flowlauncher_plugin_calculator_decimal_separator_dot))] | ||
| Dot, | ||
|
|
||
| [EnumLocalizeKey(nameof(Localize.flowlauncher_plugin_calculator_decimal_separator_comma))] | ||
| Comma | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't like a change like this. It just removes braces and indent and messes up commit history.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Let us revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VictoriousRaptor All related namespaces are reverted