Fix ShellPath directory for shell path selection #4203

Jack251970 · 2026-01-07T05:41:00Z

Updated OpenShellPath to use Settings.ShellPath directory when prompting for a file path, ensuring the dialog opens in the relevant location instead of the editor path directory.

From TBM13:

Updated OpenShellPath to use Settings.ShellPath directory when prompting for a file path, ensuring the dialog opens in the relevant location instead of the editor path directory.

gitstream-cm · 2026-01-07T05:41:51Z

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

Activity based on git-commit:

	Jack251970
JAN
DEC
NOV
OCT
SEP	9 additions & 9 deletions
AUG

Knowledge based on git-blame:
Jack251970: 97%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

gitstream-cm · 2026-01-07T05:42:00Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

coderabbitai · 2026-01-07T05:43:28Z

📝 Walkthrough

Walkthrough

Modified SettingsViewModel.cs in the Explorer plugin to derive the file dialog path for the OpenShellPath command from Settings.ShellPath instead of Settings.EditorPath. No other logic changes.

Changes

Cohort / File(s)	Summary
Settings property source update `Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs`	Changed OpenShellPath command initialization to use `Settings.ShellPath` as the base directory instead of `Settings.EditorPath`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

onesounds

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly describes the main change: fixing the ShellPath directory used for shell path selection in the file dialog.
Description check	✅ Passed	The description is directly related to the changeset, explaining why the change was made and what it accomplishes in the context of the file dialog behavior.

_{✏️ Tip: You can configure your own custom Pre-merge Checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d4e03b and 382a77d.

📒 Files selected for processing (1)

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: Yusyuriv
Repo: Flow-Launcher/Flow.Launcher PR: 3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:40:11.014Z
Learning: In Flow Launcher, when using Windows Forms dialogs (e.g., in `JsonRPCPluginSettings.cs`), path validation is enabled by default in `OpenFileDialog` and `FolderBrowserDialog`, preventing users from selecting invalid paths, but it's possible to opt out of this validation on individual dialogs.

📚 Learning: 2024-11-03T07:40:11.014Z

Learnt from: Yusyuriv
Repo: Flow-Launcher/Flow.Launcher PR: 3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:40:11.014Z
Learning: In Flow Launcher, when using Windows Forms dialogs (e.g., in `JsonRPCPluginSettings.cs`), path validation is enabled by default in `OpenFileDialog` and `FolderBrowserDialog`, preventing users from selecting invalid paths, but it's possible to opt out of this validation on individual dialogs.

Applied to files:

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

📚 Learning: 2025-10-16T10:48:30.573Z

Learnt from: Jack251970
Repo: Flow-Launcher/Flow.Launcher PR: 3854
File: Flow.Launcher/App.xaml.cs:252-275
Timestamp: 2025-10-16T10:48:30.573Z
Learning: In Flow Launcher's App.xaml.cs, the plugin initialization block (lines 252-275) that includes PreStartPluginExecutablePathUpdate, PluginManager.LoadPlugins, PluginManager.InitializePluginsAsync, _mainVM.QueryResults(), and API.SaveAppAllSettings() does not require additional Task.Run wrappers or Dispatcher.InvokeAsync calls according to maintainer Jack251970, as the threading model is already safe as designed.

Applied to files:

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

📚 Learning: 2025-09-28T03:59:59.693Z

Learnt from: Jack251970
Repo: Flow-Launcher/Flow.Launcher PR: 3770
File: Plugins/Flow.Launcher.Plugin.Explorer/Views/RenameFile.xaml.cs:75-80
Timestamp: 2025-09-28T03:59:59.693Z
Learning: In Flow.Launcher's Explorer plugin rename dialog (RenameFile.xaml.cs), the dialog should close unconditionally after calling RenameThing.Rename(), even on validation failures, because RenameThing.Rename() displays error messages via popup notifications. This is the intended UX design.

Applied to files:

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

📚 Learning: 2025-07-01T05:46:13.251Z

Learnt from: Jack251970
Repo: Flow-Launcher/Flow.Launcher PR: 3791
File: Flow.Launcher.Core/Plugin/PluginManager.cs:293-295
Timestamp: 2025-07-01T05:46:13.251Z
Learning: In Flow.Launcher.Core/Plugin/PluginManager.cs, when checking if a plugin is modified within the PluginManager class itself, prefer using the internal static PluginModified(string id) method directly rather than going through API.PluginModified() for better performance and architectural design.

Applied to files:

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs

🧬 Code graph analysis (1)

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs (1)

Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs (1)

Settings (14-243)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: CodeQL analysis (csharp)
GitHub Check: gitStream.cm
GitHub Check: build

🔇 Additional comments (1)

Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs (1)

532-540: LGTM! Improved UX consistency.

The change correctly uses Settings.ShellPath instead of Settings.EditorPath to derive the initial directory for the file dialog. This makes the behavior consistent with OpenFileEditorPath and OpenFolderEditorPath methods (lines 513-530), where each method uses its own setting to determine where the dialog should open. This is more intuitive for users who are configuring the shell path.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR fixes a bug in the shell path selection dialog where it was incorrectly using the EditorPath directory as the initial location instead of the ShellPath directory. The fix ensures the file picker opens in the relevant location based on the current shell path setting.

Key Changes:

Updated OpenShellPath() method to use Settings.ShellPath directory instead of Settings.EditorPath when initializing the file selection dialog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Fix ShellPath directory for shell path selection

382a77d

Updated OpenShellPath to use Settings.ShellPath directory when prompting for a file path, ensuring the dialog opens in the relevant location instead of the editor path directory.

Copilot AI review requested due to automatic review settings January 7, 2026 05:41

prlabeler bot added the bug Something isn't working label Jan 7, 2026

Jack251970 enabled auto-merge January 7, 2026 05:41

github-actions bot assigned Jack251970 Jan 7, 2026

github-actions bot added this to the 2.1.0 milestone Jan 7, 2026

Copilot started reviewing on behalf of Jack251970 January 7, 2026 05:41 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix ShellPath directory for shell path selection #4203

Fix ShellPath directory for shell path selection #4203

Jack251970 commented Jan 7, 2026

Uh oh!

gitstream-cm bot commented Jan 7, 2026

Uh oh!

gitstream-cm bot commented Jan 7, 2026

Uh oh!

coderabbitai bot commented Jan 7, 2026

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Fix ShellPath directory for shell path selection #4203

Are you sure you want to change the base?

Fix ShellPath directory for shell path selection #4203

Conversation

Jack251970 commented Jan 7, 2026

Uh oh!

gitstream-cm bot commented Jan 7, 2026

Uh oh!

gitstream-cm bot commented Jan 7, 2026

Uh oh!

coderabbitai bot commented Jan 7, 2026

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants