Skip to content

Conversation

@pc223
Copy link
Contributor

@pc223 pc223 commented Jun 21, 2021

Why: GetMethod(String) raise AmbiguousMatchException when method have overloads (e.g. ShowMsg)

Solution: Use GetMethod(String, Type[])

https://stackoverflow.com/questions/1969411/avoiding-an-ambiguous-match-exception

Why: `GetMethod(String)` raise AmbiguousMatchException when method have overloads (e.g. `ShowMsg`)

Solution: `Use GetMethod(String, Type[])`

https://stackoverflow.com/questions/1969411/avoiding-an-ambiguous-match-exception
@pc223
Copy link
Contributor Author

pc223 commented Jun 21, 2021

@jjw24 @taooceros Please help review, I'm not sure about C# and Git in general 😅

@taooceros
Copy link
Member

taooceros commented Jun 21, 2021

@jjw24 @taooceros Please help review, I'm not sure about C# and Git in general 😅

Sure. Give me a few minutes.

@taooceros
Copy link
Member

@pc223 Have you checked whether this commit fix the issue?

Though, it looks nice to me. Thank you.

@taooceros taooceros marked this pull request as ready for review June 21, 2021 08:47
@pc223
Copy link
Contributor Author

pc223 commented Jun 21, 2021

@pc223 Have you checked whether this commit fix the issue?

Though, it looks nice to me. Thank you.

Yes, I built it local on my machine, tested with the ShowMsg method, and a python plugin

@taooceros
Copy link
Member

By the way, you have done a much better job than my first commit lol. I have messed around a lot when I try to contribute earlier. #171 #172 🤣🤣

@taooceros taooceros added this to the 1.8.0 milestone Jun 21, 2021
@pc223
Copy link
Contributor Author

pc223 commented Jun 21, 2021

By the way, you have done a much better job than my first commit lol. I have messed around a lot when I try to contribute earlier. #171 #172 🤣🤣

Haha Git/Github is pretty confusing to me, still learning to wrap my head around these branches and origins and stuff.

Wish that we can have tools design for normal people to collaborate 🤔 (Flow/Wox users are a lot non-programmer/hobbyist/powerusers)

@taooceros
Copy link
Member

Maybe github desktop is great if you don't like command line. Though, it's also nice to use command line git once getting used to it.

@taooceros taooceros merged commit 6b3f2e2 into Flow-Launcher:dev Jun 21, 2021
@pc223 pc223 deleted the fix-ambiguous-match-plugin-api branch June 21, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants