Skip to content

Adjust websearch plugin & Small Fix for pluginstore PR & Setting Popup Redesign #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 2, 2021
Merged

Adjust websearch plugin & Small Fix for pluginstore PR & Setting Popup Redesign #779

merged 11 commits into from
Nov 2, 2021

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Oct 29, 2021 •
edited
Loading

This PR for Fix #774

  • Adjust Websearch Plugin layout
  • Adjust Websearch source setting Popup window design & Priority popup window design
    Based fluent design document.
  • Add/Adjust related String

and include #776

  • Change Hyper link in setting>Theme>Browse more themes
  • Add some string
  • Fix plugin listbox scrollviewer large bottom space problem when open websearch plugin.

onesounds and others added 5 commits October 28, 2021 10:38
@onesounds
- change the 'browse more theme' in theme setting, to 'how to create …
4d76640 
…theme'

- change the hyperlink
- add 'how to create theme' string in english.
- change string 'browseMoreThemes' text 'Browser for more themes' to 'Theme gallery'. It will use later.
@onesounds
add ScrollViewer.CanContentScroll="False"
fdcab69
@taooceros
Format code
37281a1 
Add new line for property for better format
@onesounds
- Adjust Priority Change Popup Window Design
0edbcfd 
- Adjust Websearch setting layout
- Change and add Websearch String
- Change Websearch popup design
@onesounds
Merge branch 'SmallFix' into AdjustWebsearchPlugin
6e850cd
@onesounds onesounds mentioned this pull request Oct 29, 2021
Closed
@onesounds onesounds requested a review from jjw24 October 29, 2021 17:47
@onesounds onesounds self-assigned this Oct 29, 2021
@onesounds onesounds added bug Something isn't working kind/ui related to UI, icons, themes, etc labels Oct 29, 2021
@onesounds onesounds mentioned this pull request Oct 29, 2021
Closed
@onesounds
Add Noresize property in setting search source popup
89e2edb
@onesounds
- add netflix / youtube music
43a62d0 
- add netflix / youtube music icon
- change list array order
- remove findicon.com
- add search source setting guide string
@onesounds
Copy link
Contributor Author

onesounds commented Oct 29, 2021 •
edited
Loading

  • Add Guide in setting source popup window
  • add Netflix / Youtube music websearch in default list & change order
  • add netflix / youtube icon
  • Remove Findicons.com (I want remove I'm feeling lucky too!')

Spotify has a plug-in, and I didn't put it in because I thought there would be a problem of confusing each other. I only put Netflix and YouTube music.

@onesounds onesounds changed the title Adjust websearch plugin & Small Fix for pluginstore PR Adjust websearch plugin & Small Fix for pluginstore PR & Setting Popup Redesign Oct 29, 2021
@onesounds
- Add CustomQuery Hotkey Tips String
0e5d5ec 
- Adjust CustomQueryHotkey Setting Popup Layout
- Change HotkeyControl to using popup
- Add some code to closing popup when click out area
@onesounds
Copy link
Contributor Author

onesounds commented Oct 29, 2021 •
edited
Loading

Before

After

  • Adjust CustomQueryHotkey Setting Popup Layout
  • Change HotkeyControl to using popup
    • Since the key change confirmation text is displayed on the left or right, it is problem with some layout. so It needed to change.
    • Add some code to closing popup when click out of area
    • small problem
      • When dragging a window, the pop-up remains in that position.
      • In the case of special key input (a situation in which an alt is pressed), showing an empty pop-up.

In general situations, there is no problem, and the problem is not critical, so I push it for now. Since the action keyword window modification work remains, it will be modified while continuing to work.

@onesounds
- add action keyweword title string
a244570 
- add some additional tip string
- adjust action keyword setting popup layout
@onesounds
Copy link
Contributor Author

Before

After

Done. Time to Test.

@onesounds
- Remove URL
4e5975c 
- Add Icon
@onesounds
Copy link
Contributor Author

image

@jjw24 jjw24 force-pushed the AdjustWebsearchPlugin branch 2 times, most recently from bd210c3 to c2a6330 Compare November 2, 2021 22:07
@jjw24 jjw24 enabled auto-merge November 2, 2021 22:08
@jjw24 jjw24 added this to the 1.9.0 milestone Nov 2, 2021
@jjw24
Copy link
Member

jjw24 commented Nov 2, 2021 •
edited
Loading

it's annoying when add/remove search sources, because they have to be backwards compatible- for users that already have flow installed the new search sources do not show up, and for removals the action keyword will be retained in the main settings file unless manually remove it . So lets do them in a seperate pr- #787

@jjw24 jjw24 merged commit ddda425 into Flow-Launcher:dev Nov 2, 2021
@jjw24 jjw24 mentioned this pull request Dec 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@onesounds onesounds

Labels
bug Something isn't working kind/ui related to UI, icons, themes, etc
Projects
No open projects
WIP
Status: Done
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

The place I search for and the place I receive search recommendations are different.
3 participants
@onesounds @jjw24 @taooceros