Skip to content

Fix BookmarkDataSetting key string #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Fix BookmarkDataSetting key string #923

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ee43d
fix bookmark string
taooceros Dec 19, 2021
99ba1b7
fix key name
jjw24 Dec 19, 2021
7e1f041
Merge remote-tracking branch 'origin/dev' into fixSourceString
jjw24 Dec 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Plugins/Flow.Launcher.Plugin.BrowserBookmark/Languages/en.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<system:String x:Key="flowlauncher_plugin_browserbookmark_plugin_description">Search your browser bookmarks</system:String>

<!-- Settings -->
<system:String x:Key="BookmarkDataSetting">Bookmmark Data</system:String>
<system:String x:Key="BookmarkDataSetting">Bookmark Data</system:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however this name does not conform with others, may have a slight chance to cause clash. let's use this pr to fix

<system:String x:Key="flowlauncher_plugin_browserbookmark_settings_openBookmarks">Open bookmarks in:</system:String>
<system:String x:Key="flowlauncher_plugin_browserbookmark_settings_newWindow">New window</system:String>
<system:String x:Key="flowlauncher_plugin_browserbookmark_settings_newTab">New tab</system:String>
Expand Down