-
-
Notifications
You must be signed in to change notification settings - Fork 456
Improvements to PluginManager plugin #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
since the `UrlSourceCode` field is inconsistent in the manifest file
|
Should we expand the helper class instead of creating a new httpclient for plugins manager only? Also this may not follow the proxy setting. |
Yup, you're right, I wanted to keep it simple but I forgot about proxy settings... Will add a helper method inside |
|
There's one issue I just noticed: launching Flow and opening Possible workarounds:
thoughts? |
|
I would consider that we just call download manifest in init? We can decide not to await that so it won't change init time. |
Alright, was hoping for this since I am not very familiar with WPF 😛 It's pretty fast with the CDN link, anyways... |
lol it's not related to WPF. Flow waits for plugin init before showing up. |
I meant my other solution, the second one ;) |
no point for it, anymore
Rename them to something more accurate, switch them to be const
The main change introduced here is the use of conditional http requests when fetching the plugin manifest json. This allows us to always check for changes to the manifest repo when running one of
pm install,pm update, with very little performance overhead (for me it is about 50ms). It also allows us to simplify the relevant code a bit.Also some quick refactoring in
PluginsManagerand a couple quality-of-life enhancements:pm instand hitting tab would autocomplete topm installwithout a space at the end (same for the other base commands)PS: I missed #682 until I started writing this PR text... my apologies. I see similarities, perhaps we can pick some of the missing changes into this PR?