Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Dec 29, 2024

This PR adds a tests for checking shareable public key on my_keys.htm on FlowCrypt Settings -> Public Key.

close #4618


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner December 29, 2024 12:09
@martgil martgil marked this pull request as draft December 29, 2024 12:09
@martgil martgil marked this pull request as ready for review December 30, 2024 05:32
@martgil
Copy link
Collaborator Author

martgil commented Dec 30, 2024

Hello @sosnovsky - this one is ready for a review. thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@sosnovsky sosnovsky enabled auto-merge (squash) January 1, 2025 22:11
@sosnovsky sosnovsky merged commit cab7e5a into master Jan 1, 2025
12 of 13 checks passed
@sosnovsky sosnovsky deleted the issue-4618-add-test-for-shareable-pubkey-link branch January 1, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing test: "Share your Public Key" link

2 participants