-
Notifications
You must be signed in to change notification settings - Fork 51
#5900 Fix delay issue when adding secure messaging action buttons on Gmail context menu #5901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Hello @sosnovsky - This one is ready for a review. Thank you! |
extension/js/content_scripts/webmail/gmail/gmail-element-replacer.ts
Outdated
Show resolved
Hide resolved
Good afternoon, @sosnovsky, I believe this is now ready for your review. I would also like to request that you test it to ensure it meets your expectations. From my side, the result looks excellent, and I love how it works now compared to the initial implementation. Looking forward to your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, works much faster now 👍
extension/js/content_scripts/webmail/gmail/gmail-element-replacer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍
This PR fixes the delay issue when the extension tried to add the secure messaging action buttons on Gmail context menu.
close #5900
Screen recording of the propose fix:
Screen.Recording.2025-01-17.at.3.25.14.PM.mov
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):