Skip to content

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Feb 5, 2025

This PR updates version to 8.5.9 and adds changelog + sticks with web-ext v7, as v8 doesn't support node16 used on our deploy infrastructure.


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from ioanmo226 February 5, 2025 08:26
@sosnovsky
Copy link
Collaborator Author

Why is snyk failing? I don't have access to snyk (Just requested access though)

I don't have access to it too, and not sure which change can cause snyk check failure.

@DenBond7 do you have access to Snyk dashboard?

@martgil
Copy link
Collaborator

martgil commented Feb 5, 2025

I check it too on my account and I do not have access to Snyk from this repo.

@DenBond7
Copy link

DenBond7 commented Feb 5, 2025

@DenBond7 do you have access to Snyk dashboard?

@sosnovsky I've checked. I have no access. Please ask @tomholub for help.

@sosnovsky
Copy link
Collaborator Author

@ioanmo226 looks like snyk issue was caused by web-ext downgrade, I reverted it to v8 and snyk check has passed

@sosnovsky
Copy link
Collaborator Author

For web-ext, is it fine to push v8 to master?

Yes, it's used only when creating new firefox releases, so pushing to master doesn't affect any functionality.

@sosnovsky sosnovsky requested a review from ioanmo226 February 5, 2025 10:22
@ioanmo226 ioanmo226 merged commit c8f3c28 into master Feb 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants