Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Mar 13, 2025

This PR adds a check to determine if the user is importing a private key with a newer expiry date than the existing one and notifies the user accordingly.

close #5947


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner March 13, 2025 08:09
@martgil martgil marked this pull request as draft March 13, 2025 08:09
@martgil
Copy link
Collaborator Author

martgil commented Mar 13, 2025

wip: currently adding ui test

@martgil martgil marked this pull request as ready for review March 21, 2025 10:36
@martgil
Copy link
Collaborator Author

martgil commented Mar 21, 2025

Hi @sosnovsky - This one is ready for a review. Thank you!

@martgil martgil marked this pull request as draft March 24, 2025 10:33
@martgil martgil marked this pull request as ready for review March 26, 2025 06:29
@martgil martgil marked this pull request as draft March 26, 2025 07:01
@martgil martgil marked this pull request as ready for review March 26, 2025 07:54
@martgil martgil requested a review from sosnovsky March 26, 2025 07:54
@martgil
Copy link
Collaborator Author

martgil commented Mar 26, 2025

Hi again @sosnovsky could you please kindly re-check this PR? thanks.

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, redirect to update key page is much more convenient 👍

@sosnovsky sosnovsky merged commit 1174015 into master Mar 26, 2025
12 checks passed
@sosnovsky sosnovsky deleted the issue-5947-detected-newer-key-version-upon-key-import branch March 26, 2025 12:30
@martgil
Copy link
Collaborator Author

martgil commented Mar 27, 2025

Thanks for your recommendation and for making it possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggested Improvement] Offer private update when imported an updated version of existing key

2 participants