-
Notifications
You must be signed in to change notification settings - Fork 51
#5947 Add info modal for key with newer expiry than existing key #5951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5947 Add info modal for key with newer expiry than existing key #5951
Conversation
wip: currently adding ui test |
…-newer-key-version-upon-key-import
…-newer-key-version-upon-key-import
…-newer-key-version-upon-key-import
Hi @sosnovsky - This one is ready for a review. Thank you! |
Hi again @sosnovsky could you please kindly re-check this PR? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, redirect to update key page is much more convenient 👍
Thanks for your recommendation and for making it possible. |
This PR adds a check to determine if the user is importing a private key with a newer expiry date than the existing one and notifies the user accordingly.
close #5947
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):