Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Mar 18, 2025

This PR preserves user ids upon fixing keys.

close #5956


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner March 18, 2025 08:05
@martgil martgil marked this pull request as draft March 18, 2025 08:05
@martgil martgil marked this pull request as ready for review March 28, 2025 10:41
@martgil

This comment was marked as off-topic.

@sosnovsky
Copy link
Collaborator

hi @martgil, extension fails to build here and there are some issues found by ESLint, please check them too, thanks!

@martgil

This comment was marked as outdated.

@martgil
Copy link
Collaborator Author

martgil commented Apr 2, 2025

Hi again @sosnovsky - this one is ready for a review. Thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@sosnovsky sosnovsky merged commit f5874d3 into master Apr 4, 2025
12 checks passed
@sosnovsky sosnovsky deleted the issue-5956-preserve-original-userids-during-key-fix branch April 4, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve valid user IDs during key fix attempts

2 participants