Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Mar 20, 2025

This PR updates the compatibility.ts output of the key's expiration field to be formatted in ISO Format rather than in Epoch time for quick recognition of the expiry date.

Closes #5955


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner March 20, 2025 07:53
@martgil martgil marked this pull request as draft March 20, 2025 07:53
@martgil martgil marked this pull request as ready for review April 2, 2025 08:40
@martgil
Copy link
Collaborator Author

martgil commented Apr 2, 2025

Hi @sosnovsky - This one is ready for a review as well. Thanks!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@sosnovsky sosnovsky merged commit 5cf7ed3 into master Apr 4, 2025
12 checks passed
@sosnovsky sosnovsky deleted the issue-5955-compatibility-uses-iso-expiration-date-format branch April 4, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add human-readable expiration convertion in compatibility.htm

2 participants