Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Apr 3, 2025

This PR does fix .asc public key attachment not recognized.

Fix:

image

Current behavior:

image

Closes #5966


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner April 3, 2025 07:23
@martgil martgil marked this pull request as draft April 3, 2025 07:23
@martgil martgil marked this pull request as ready for review April 3, 2025 07:52
@martgil
Copy link
Collaborator Author

martgil commented Apr 3, 2025

Hi @sosnovsky, this one is ready for a review. thanks!

@martgil martgil changed the title #5966 refactor: add reliable checks for ambigious file extensions #5966 Add reliable checks for ambigious file extensions Apr 4, 2025
@martgil martgil requested a review from sosnovsky April 7, 2025 06:28
@martgil
Copy link
Collaborator Author

martgil commented Apr 7, 2025

Hi again @sosnovsky, I've added a small test for this change. Do you think it will be sufficient?

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now, thanks!

@sosnovsky sosnovsky merged commit dbe25b2 into master Apr 7, 2025
12 checks passed
@sosnovsky sosnovsky deleted the issue-5966-fix-invalid-assumption-on-ambigious-filename-extension branch April 7, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public key detection doesn't work reliably on certain public key attachment

2 participants