Skip to content

#6033 Fix: failed to fetch dynamatically imported module issue #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

#6033 Fix: failed to fetch dynamatically imported module issue #6039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a510c23
fix: failed to fetch dynamatically imported module issue
ioanatflowcrypt Jul 4, 2025
bbf0b50
Merge branch 'master' into 6033-failed-to-fetch-dynamatically-importe…
ioanatflowcrypt Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions extension/js/common/platform/catch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

'use strict';

import type { ExternalService as IExternalService } from '../api/account-servers/external-service.js';
import { Env } from '../browser/env.js';
import { Url } from '../core/common.js';
import { FLAVOR, VERSION } from '../core/const.js';
import { CatchHelper } from './catch-helper.js';
Expand Down Expand Up @@ -280,9 +282,26 @@ export class Catch {
return;
}

// eslint-disable-next-line @typescript-eslint/naming-convention
const { ExternalService } = await import('../api/account-servers/external-service.js');
const externalService = new ExternalService(acctEmail);
let externalService: IExternalService;
if (Env.isContentScript()) {
/**
* – In content-script builds, the class is already bundled in `webmail_bundle.js`
* so we just grab it from the global scope.
* ⚠️ If we *ever* try to dynamically import this module from a content-script
* the browser will throw:
* “Denying load of chrome-extension://…/external-service.js.
* Resources (including all dependencies this file uses) must be listed in the web_accessible_resources manifest key”
*/
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
externalService = new ExternalService(acctEmail);
} else {
// eslint-disable-next-line @typescript-eslint/naming-convention
const { ExternalService } = await import('../api/account-servers/external-service.js');
externalService = new ExternalService(acctEmail);
}

await externalService.setUrlBasedOnFesStatus();
await externalService.reportException(errorReport);
}
Expand Down
Loading