Skip to content

Conversation

ioanatflowcrypt
Copy link
Collaborator

@ioanatflowcrypt ioanatflowcrypt commented Jul 14, 2025

This PR uses named types for api request params

close #5477 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt ioanatflowcrypt marked this pull request as ready for review July 15, 2025 09:15
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much more readable now 👍

@sosnovsky sosnovsky merged commit 0ffbbcf into master Jul 15, 2025
12 checks passed
@sosnovsky sosnovsky deleted the 5477-use-named-types-for-api-request-params branch July 15, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use named types for API request params

2 participants