Skip to content

#6056 Live test fix #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2025
Merged

#6056 Live test fix #6076

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91a1f53
fix: gmail chat test
ioanatflowcrypt Sep 9, 2025
35769d5
fix: test
ioanatflowcrypt Sep 10, 2025
4ac3cf2
fix: test
ioanatflowcrypt Sep 10, 2025
6e0d473
fix: only
ioanatflowcrypt Sep 10, 2025
6a92620
fix: test
ioanatflowcrypt Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions test/source/tests/gmail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,11 @@
expect(urls.length).to.equal(0);
};

const openGmailPage = async (t: AvaContext, browser: BrowserHandle): Promise<ControllablePage> => {
const url = TestUrls.gmail(0);
const openGmailPage = async (t: AvaContext, browser: BrowserHandle, path?: string): Promise<ControllablePage> => {
let url = TestUrls.gmail(0);
if (path) {
url = TestUrls.gmail(0, path, 'inbox');
}
return await browser.newPage(t, url);
};

Expand Down Expand Up @@ -401,8 +404,7 @@
'mail.google.com - plain reply to encrypted and signed messages',
testWithBrowser(async (t, browser) => {
await BrowserRecipe.setUpCommonAcct(t, browser, 'ci.tests.gmail');
const gmailPage = await openGmailPage(t, browser);
await gotoGmailPage(gmailPage, '/FMfcgzGkbDRNgcQxLmkhBCKVSFwkfdvV'); // plain convo
const gmailPage = await openGmailPage(t, browser, '/FMfcgzGkbDRNgcQxLmkhBCKVSFwkfdvV'); // plain convo
await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 1 });
await gotoGmailPage(gmailPage, '/181d226b4e69f172'); // go to encrypted convo
await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 1 });
Expand Down Expand Up @@ -578,14 +580,13 @@
);

// convo-sensitive, draft-sensitive test
test.serial(
test.only(
'mail.google.com - plain reply draft',
testWithBrowser(
async (t, browser) => {
await BrowserRecipe.setUpCommonAcct(t, browser, 'ci.tests.gmail');
const gmailPage = await openGmailPage(t, browser);
const threadId = '181d226b4e69f172'; // 1st message -- thread id
await gotoGmailPage(gmailPage, `/${threadId}`); // go to encrypted convo
const gmailPage = await openGmailPage(t, browser, `/${threadId}`);
await GmailPageRecipe.trimConvo(gmailPage, threadId);
await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 5 });
t.timeout(minutes(2)); // extend ava's timeout
Expand Down
7 changes: 4 additions & 3 deletions test/source/tests/tooling/browser-recipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,12 @@ export class BrowserRecipe {
public static openGoogleChatPage = async (t: AvaContext, browser: BrowserHandle, googleLoginIndex = 0) => {
const googleChatPage = await browser.newPage(t, TestUrls.googleChat(googleLoginIndex));
await Util.sleep(5);
if (await googleChatPage.isElementPresent('.fKz7Od')) {
const chatFrame = await googleChatPage.getFrame(['https://chat.google.com/u/0/mole/world']);
if (await chatFrame.isElementPresent('.fKz7Od')) {
// close announcement about updated UI
await googleChatPage.waitAndClick('.fKz7Od', { delay: 1 });
await chatFrame.waitAndClick('.fKz7Od', { delay: 1 });
}
await googleChatPage.waitAny(['a.gb_6d', 'a.gb_Fc', 'a.gb_9d', 'a.gb_7d']); // Google hangout logo
await chatFrame.waitAny(['a.gb_6d', 'a.gb_Fc', 'a.gb_9d', 'a.gb_7d', 'a.gb_ce', 'a.gb_Sc']); // Google hangout logo
return googleChatPage;
};

Expand Down
Loading