Skip to content

Conversation

@ioanatflowcrypt
Copy link
Collaborator

This PR improved my keys section

image

close #6114 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt ioanatflowcrypt marked this pull request as ready for review November 25, 2025 08:46
@ioanatflowcrypt ioanatflowcrypt mentioned this pull request Nov 25, 2025
5 tasks
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make it more compact, like the previous version - in the current design only 2 keys are visible without scrolling, while previous layout showed 5 keys on the screen. it should be possible to fit full key information into a single line

old:
Image

new:
Image

@ioanatflowcrypt
Copy link
Collaborator Author

Sounds good. Fixed and pushed

@ioanatflowcrypt
Copy link
Collaborator Author

image

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better now 👍

Comment on lines +547 to +548
// Compact layout: reduced padding via CSS (4px), no inline padding here.
// Added white-space: nowrap and overflow handling to keep single line.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for these comments, let's remove them

Comment on lines +527 to +528
<div class="col-5">Fingerprint</div>
<div class="col-2">Status</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use col-6 for fingerprint and col-1 for status column, as currently fingerprint isn't fully fit on 1280px screen width:

Image

Comment on lines +31 to +32
#header-row .logo-row .subscription>span,
#header-row .logo-row .subscription>button {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like broken css formatting - there should be spaces around >

}

@media (width <= 991px) {
@media (width <=991px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve "My keys" section

3 participants