-
Notifications
You must be signed in to change notification settings - Fork 52
#6114 Improved my keys section #6121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sosnovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Sounds good. Fixed and pushed |
sosnovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks much better now 👍
| // Compact layout: reduced padding via CSS (4px), no inline padding here. | ||
| // Added white-space: nowrap and overflow handling to keep single line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for these comments, let's remove them
| <div class="col-5">Fingerprint</div> | ||
| <div class="col-2">Status</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #header-row .logo-row .subscription>span, | ||
| #header-row .logo-row .subscription>button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like broken css formatting - there should be spaces around >
| } | ||
|
|
||
| @media (width <= 991px) { | ||
| @media (width <=991px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here too




This PR improved my keys section
close #6114 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):