Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jan 15, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Corrected source code tab language configuration to use the proper language annotation property, ensuring syntax highlighting displays correctly when language settings are specified.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Walkthrough

Fixed a bug in TabbedDemo's createSourceCodeTab method where the language annotation attribute was incorrectly sourced from the caption field. The language assignment now correctly uses annotation.language() instead of annotation.caption().

Changes

Cohort / File(s) Summary
Language attribute correction
src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java
Updated createSourceCodeTab to assign language from annotation.language() instead of annotation.caption(), fixing incorrect field dependency

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the initialization of the SourceCodeTab language attribute by correcting which annotation property is used.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9ccfcf and 524d2bb.

📒 Files selected for processing (1)
  • src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java
🔇 Additional comments (1)
src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java (1)

244-246: LGTM! Correct fix for the copy-paste error.

The language attribute is now correctly initialized using annotation.language() instead of annotation.caption(). The fix follows the same pattern used for the caption attribute above.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@paodb paodb merged commit 5702831 into master Jan 15, 2026
3 checks passed
@paodb paodb deleted the fix-20260115 branch January 15, 2026 18:42
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

3 participants