fix: correct JavaScript Date to string transformation

[javier-godoy]

Close #100

Summary by CodeRabbit

• Bug Fixes
  • Improved date handling in the date picker to generate month keys consistently across time zones and environments.
  • Prevents rare off-by-one-month issues that could affect month grouping, selection, or highlighting.
  • Enhances reliability of date-based styling without altering the visible UI or workflow.

[coderabbitai]

Walkthrough

Replaced date.toISOString().substr(0,7) with this._formatISO(date).substr(0,7) in fc-date-picker’s _getStyle method to derive the month key using the component’s ISO formatter.

Changes

Cohort / File(s)	Change summary
Date formatting normalization src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js	In _getStyle, switched month key generation from date.toISOString().substr(0,7) to this._formatISO(date).substr(0,7). No other logic changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: fix timezone handling in inline-date-picker #90 — Similar change replacing direct toISOString() usage with a helper formatter for deriving component state.

Suggested reviewers

• mlopezFC
• paodb

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “fix: correct JavaScript Date to string transformation” clearly and concisely summarizes the primary change of adjusting the date-to-string logic, matching the main intent of the PR without extraneous detail or ambiguity.
Linked Issues Check	✅ Passed	The change replaces the UTC-based date.toISOString().substr(0,7) call with this._formatISO(date).substr(0,7), directly addressing issue #100’s requirement to avoid UTC conversion and prevent month shifting for non-UTC clients.
Out of Scope Changes Check	✅ Passed	The only modification in this PR is the localized date formatting in fc-date-picker.js to correct the month key logic, and there are no unrelated or additional code changes introduced beyond the scope of the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-100

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bd7f50 and cbb95fa.

📒 Files selected for processing (1)

• src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: javier-godoy
PR: FlowingCode/YearMonthCalendarAddon#96
File: src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js:128-132
Timestamp: 2025-04-24T17:59:52.000Z
Learning: In the YearMonthCalendarAddon project, the DatePicker component uses custom formatting functions (`__formatDate` and `__parseDate`) rather than `this.locale` for date formatting and localization.

📚 Learning: 2025-04-24T17:59:52.000Z

Learnt from: javier-godoy
PR: FlowingCode/YearMonthCalendarAddon#96
File: src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js:128-132
Timestamp: 2025-04-24T17:59:52.000Z
Learning: In the YearMonthCalendarAddon project, the DatePicker component uses custom formatting functions (`__formatDate` and `__parseDate`) rather than `this.locale` for date formatting and localization.

Applied to files:

• src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js

[paodb]

Quality Gate failed

Failed conditions E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Issue created #102