fix: increment day when button is clicked before input focus

[javier-godoy]

Summary by CodeRabbit

• Bug Fixes
  • Improved date increment behavior in the date picker: when the input is not focused, incrementing now always adjusts the day component, ensuring more predictable and consistent user interactions.

[coderabbitai]

Walkthrough

The update modifies the internal logic of the date picker component's JavaScript file. It introduces an event listener for the input element's focus event to track when the input is focused. In the method handling button clicks for incrementing date parts, the logic now distinguishes between focused and unfocused states: if the input is focused, the incremented part is determined by the cursor position; if unfocused, the day component is incremented by default. No changes are made to the public API or method signatures.

Changes

File Path	Change Summary
src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js	Added input focus event listener to set internal flag; updated button click logic to vary increment behavior based on input focus state.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js (2)

73-73: Consider adding a blur event listener

You've added a focus event listener that sets __focused to true, but there's no corresponding blur listener to reset it to false. If the intention is to only handle the first-time focus differently, then this is fine. Otherwise, consider adding a blur event listener:

this.inputElement.addEventListener('focus', ()=>this.__focused=true);
+this.inputElement.addEventListener('blur', ()=>this.__focused=false);

---

161-171: The fix properly handles unfocused input state

The change correctly implements the desired behavior of incrementing the day part when the button is clicked before input focus. This provides a more intuitive default behavior.

One minor suggestion for improved readability:

      } else {
        part = 'D';
-        // find the index where D start
+        // Count how many non-digit characters appear before 'D' in the format string
        index = 0;
        for (let i=0;i<format.length && format[i]!=part;i++) {
          if (!format[i].match(/[0-9]/)) index++;
        }
      }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b376b81 and 6281b36.

📒 Files selected for processing (1)

• src/main/resources/META-INF/frontend/fc-date-picker/fc-date-picker.js (2 hunks)