Require workspace ID in various controllers and services

[vinodkiran]

Modified controller and service methods to accept workspaceId as a mandatory parameter for operations, ensuring consistent validation across the application.

[Copilot]

Pull Request Overview

This PR enforces workspace ID validation across the application by making workspaceId a mandatory parameter in controller and service methods. The changes ensure consistent workspace isolation and proper authorization checks.

Key changes:

• Modified database entity schemas to make workspaceId non-nullable
• Updated service methods to require workspaceId as a mandatory parameter
• Added workspace validation in controllers with proper error handling
• Enhanced utility functions to throw errors when workspace ID is missing

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Database entities	Changed workspaceId from optional to required field
Service layer methods	Added mandatory workspaceId parameters to all CRUD operations
Controller methods	Added workspace validation with error handling
Utility functions	Enhanced workspace search options to validate required workspace ID
Interface definitions	Updated type definitions to reflect mandatory workspace requirements

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[hob]

This workspace check is duplicated many times. You should wrap it in a function:

const workspaceRequiredPrecondition = (user: User | undefined, func: Function): any => {
    const workspaceId = user?.activeWorkspaceId
    if (!workspaceId) {
        throw new InternalFlowiseError(
            StatusCodes.NOT_FOUND,
            `Error: assistantsController.getAllAssistants - workspace ${workspaceId} not found!`
        )
    }
    const result = func()
    if (result instanceof Promise) {
        return await result
    } else {
        return result
    }
}

const createAssistant = async (req: Request, res: Response, next: NextFunction) => {
...
        return await workspaceRequiredPrecondition(req, () => {
            const subscriptionId = req.user?.activeOrganizationSubscriptionId || ''

            const existingAssistantCount = await assistantsService.getAssistantsCountByOrganization(body.type, orgId)
            const newAssistantCount = 1
            await checkUsageLimit('flows', subscriptionId, getRunningExpressApp().usageCacheManager, existingAssistantCount + newAssistantCount)

            body.workspaceId = workspaceId
            const apiResponse = await assistantsService.createAssistant(body, orgId)

            return res.json(apiResponse)
        })
    } catch (error) {
        next(error)
    }
}

const deleteAssistant = async (req: Request, res: Response, next: NextFunction) => {
    try {
        if (typeof req.params === 'undefined' || !req.params.id) {
            throw new InternalFlowiseError(
                StatusCodes.PRECONDITION_FAILED,
                `Error: assistantsController.deleteAssistant - id not provided!`
            )
        }
        const apiResponse = await workspaceRequiredPrecondition(
            req.user,
            assistantsService.deleteAssistant(req.params.id, req.query.isDeleteBoth, workspaceId)
        )
        return res.json(apiResponse)
    } catch (error) {
        next(error)
    }
}

[HenryHengZJ]

switching to #5228