-
-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Modify to node user #5495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modify to node user #5495
Conversation
Summary of ChangesHello @chungyau97, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on bolstering the security posture of the Docker image by adjusting user permissions within the Dockerfile. It removes the explicit use of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves security by switching the Docker container to run as a non-root node user, which is a commendable change. However, the current implementation has a couple of significant issues. Firstly, the file permission change with chown is too specific and may lead to runtime failures if the application attempts to install global dependencies. Secondly, and more critically, this change will break existing user setups that rely on the provided docker-compose.yml, because the data volume is mounted to a directory that will be inaccessible to the node user. I've provided detailed comments with suggestions to address these points. It's also worth noting that other Dockerfiles in the repository, like docker/worker/Dockerfile, have not been updated to run as a non-root user, leading to inconsistency.
Description
Modify
./docker/DockerFilefile from root to node user.Results