Skip to content

Conversation

@moona3k
Copy link
Contributor

@moona3k moona3k commented Nov 22, 2025

Lunary tool-error logs were using the LLM run tracker, so tool call failures showed under the wrong span. This PR points the tool-error handler to the tool tracker so failures tag the correct span. Every other analytics provider (LangSmith, LangFuse, etc) already follows this pattern.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @moona3k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific logging inaccuracy within the Lunary integration. Previously, errors originating from tools were mistakenly attributed to the LLM run tracker, leading to miscategorized failure spans. The change redirects these error logs to the correct tool tracker, ensuring that all tool-related failures are accurately recorded and easily identifiable for debugging and monitoring purposes.

Highlights

  • Lunary Tool-Error Logging Fix: Corrected an issue where Lunary tool-error logs were incorrectly associated with the LLM run tracker. The fix ensures that tool failures are now properly tagged to the dedicated tool tracker span, improving the accuracy of error reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in Lunary's tool-error logging. Previously, tool failures were incorrectly logged under the LLM run tracker, causing them to appear under the wrong span. The change correctly redirects the error logging to use the tool tracker, ensuring that tool failures are associated with the correct span. The fix is straightforward and effectively resolves the issue.

@moona3k moona3k changed the title fix lunary tool-error logging fix: correct lunary tool-error logging Nov 22, 2025
@moona3k moona3k changed the title fix: correct lunary tool-error logging fix: correct Lunary tool-error logging Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant