TASK: Fix thrown Exceptions

Author: daniellienert

Classes/Domain/Model/Index.php

@@ -157,12 +157,13 @@ public function exists(): bool
      * @param string $content
      * @param bool $prefixIndex
      * @return Response
-     * @throws \Exception
+     * @throws ElasticSearchException
+     * @throws \Neos\Flow\Http\Exception
      */
-    public function request(string $method, ?string $path = null, array $arguments = [], ?string $content = null, bool $prefixIndex = true): Response
+    public function request(string $method, string $path = null, array $arguments = [], string $content = null, bool $prefixIndex = true): Response
     {
         if ($this->client === null) {
-            throw new \Exception('The client of the index "' . $this->name . '" is not set, hence no requests can be done.', 1566313883);
+            throw new ElasticSearchException('The client of the index "' . $this->name . '" is not set, hence no requests can be done.', 1566313883);
         }
         $path = ($path ? trim($path) : '');
         if ($prefixIndex === true) {
@@ -175,8 +176,8 @@ public function request(string $method, ?string $path = null, array $arguments =
     }
 
     /**
-     * @return void
-     * @throws \Exception
+     * @throws ElasticSearchException
+     * @throws \Neos\Flow\Http\Exception
      */
     public function create(): void
     {
@@ -199,8 +200,8 @@ protected function getSettings()
     }
 
     /**
-     * @return void
-     * @throws \Exception
+     * @throws ElasticSearchException
+     * @throws \Neos\Flow\Http\Exception
      */
     public function updateSettings()
     {
@@ -217,6 +218,8 @@ public function updateSettings()
 
     /**
      * @return void
+     * @throws ElasticSearchException
+     * @throws \Neos\Flow\Http\Exception
      */
     public function delete()
     {
@@ -227,6 +230,8 @@ public function delete()
      * Refresh the index
      *
      * @return void
+     * @throws ElasticSearchException
+     * @throws \Neos\Flow\Http\Exception
      */
     public function refresh()
     {

Classes/Transfer/Exception.php

@@ -32,6 +32,13 @@ class Exception extends ElasticSearchException
      */
     protected $request;
 
+    /**
+     * @param string $message
+     * @param int $code
+     * @param ResponseInterface $response
+     * @param RequestInterface|null $request
+     * @param \Exception|null $previous
+     */
     public function __construct($message, $code, ResponseInterface $response, RequestInterface $request = null, \Exception $previous = null)
     {
         $this->response = $response;