Fix opening search everytime.

[tomusdrw]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the onSearchFinished callback across the Search, SearchResults, and Sidebar components to accept a boolean argument indicating whether a search query exists. Related logic and type definitions are adjusted to pass and use this parameter, enabling conditional behavior based on the presence of a search query.

Changes

File(s)	Change Summary
src/components/Search/Search.tsx	Updated onSearchFinished prop and related types from a no-argument function to a function accepting a boolean. Calls to onSearchFinished now pass true or false based on query presence.
src/components/Sidebar/Sidebar.tsx	Modified onSearchFinished callback to accept a boolean and conditionally set the active tab based on query presence.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Sidebar
    participant Search
    participant SearchResults

    User->>Sidebar: Initiate search
    Sidebar->>Search: Render Search component with onSearchFinished(hasQuery)
    Search->>SearchResults: Pass onSearchFinished(hasQuery)
    SearchResults->>Search: Call onSearchFinished(true/false) after search
    Search->>Sidebar: onSearchFinished(true/false)
    Sidebar->>Sidebar: If hasQuery==true, set activeTab to "search"

Loading

Suggested reviewers

• DrEverr
• mateuszsikora

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54c4cee and 4c7d12d.

📒 Files selected for processing (2)

• src/components/Search/Search.tsx (4 hunks)
• src/components/Sidebar/Sidebar.tsx (1 hunks)

🔇 Additional comments (5)

src/components/Sidebar/Sidebar.tsx (1)

36-41: Great improvement to the search UX!

The updated callback now only switches to the search tab when there's an actual query, while still marking the search as complete. This elegantly fixes the issue of the search tab opening unnecessarily.

src/components/Search/Search.tsx (4)

7-7: Appropriate type signature update

The function signature now correctly specifies that onSearchFinished accepts a boolean parameter, ensuring type safety throughout the component hierarchy.

---

17-17: Correctly handles empty search case

This properly signals that there's no search query when the URL has no search parameter, preventing unnecessary tab switching.

---

48-48: Type definition properly updated

The SearchResultsProps interface correctly reflects the new callback signature, maintaining type consistency.

---

115-115: Properly signals search completion with results

This correctly passes true when search results have been computed and are ready to display, signaling to the parent component that there's a meaningful search result to show.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for graypaper-reader ready!

Name	Link
🔨 Latest commit	4c7d12d
🔍 Latest deploy log	https://app.netlify.com/sites/graypaper-reader/deploys/6819ccab47c4960008e62a5c
😎 Deploy Preview	https://deploy-preview-239--graypaper-reader.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.