Improvement when displaying selected text

[chmurson]

What?

Improving displaying selected text on active/new-note; when note it no longers displays previously selected text

Summary by CodeRabbit

• Refactor
  • Removed debug logging statements from the note selection handler.
  • Optimized selection state management logic for improved code maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[netlify]

✅ Deploy Preview for graypaper-reader ready!

Name	Link
🔨 Latest commit	d0964b4
🔍 Latest deploy log	https://app.netlify.com/projects/graypaper-reader/deploys/694f08cc51d4140008a78109
😎 Deploy Preview	https://deploy-preview-353--graypaper-reader.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

Two files modified: console logging statements removed from NewNote.tsx's handleSelectionChange function, and SelectionRenderer.tsx refactored to consolidate selection string clearing logic into the primary effect instead of maintaining a separate effect.

Changes

Cohort / File(s)	Summary
Console Log Cleanup src/components/NoteManager/components/NewNote.tsx	Removed two console.log statements from handleSelectionChange; no behavioral changes
Selection Clearing Refactor src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx	Consolidated selection string clearing logic from separate effect into primary effect; now clears selection on every primary effect run (including when selectedBlocks is non-empty), changing prior behavior of clearing only when selectedBlocks becomes empty

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• fix: not displaying initially selected text #343 — Modifies the same SelectionRenderer effect handling selection string initialization/clearing and readiness checks.
• fix: broken initial selection of text on first page #333 — Changes SelectionRenderer.tsx's selection-handling effect and readiness/text-layer wiring logic.
• Redesign adding a new note #351 — Modifies src/components/NoteManager/components/NewNote.tsx alongside the main PR's console log removals.

Poem

🐰 Logs and selection cleared with care,
Effects now flow through simpler air—
One effect rules them all, you see,
Strings reset in harmony! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check	❓ Inconclusive	The title 'Improvement when displaying selected text' is generic and vague, using the non-descriptive term 'improvement' without conveying the specific issue or solution.	Consider a more specific title like 'Clear selected text display when creating new note' or 'Fix stale selection display on note activation' to better communicate the core change.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch improve-displaying-selected-text

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6f5a6d and d0964b4.

📒 Files selected for processing (2)

• src/components/NoteManager/components/NewNote.tsx
• src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx

💤 Files with no reviewable changes (1)

• src/components/NoteManager/components/NewNote.tsx

🧰 Additional context used

📓 Path-based instructions (4)

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Feature folders should keep components, hooks, and styles together in src/
Prefer hooks over Higher-Order Components (HOCs)
Colocate helper functions with their consumer components
Use PascalCase for component names
Favor semantic wrappers over long Tailwind utility class strings; complement Tailwind with @fluffylabs/shared-ui components

Files:

• src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript as the primary language with functional React components
Use camelCase for function and variable names
Use SCREAMING_SNAKE_CASE for constants

Files:

• src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use 2-space indentation

Files:

• src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx

**/*.{js,jsx,ts,tsx}

⚙️ CodeRabbit configuration file

When reviewing Tailwind CSS classes, ensure they follow Tailwind 4.x conventions and suggest modern 4.x alternatives for deprecated patterns.

Files:

• src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx

🧠 Learnings (1)

📚 Learning: 2025-10-28T20:41:06.887Z

Learnt from: chmurson
Repo: FluffyLabs/graypaper-reader PR: 333
File: src/components/PdfProvider/PdfProvider.tsx:34-37
Timestamp: 2025-10-28T20:41:06.887Z
Learning: In the graypaper-reader codebase, for text layer render tracking in PdfProvider, use RefObject<number[]> approach (textLayerRenderedRef) without adding reactive signals or version numbers. Consumers should check the ref imperatively when needed rather than reacting to changes.

Applied to files:

• src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: visual-tests

🔇 Additional comments (1)

src/components/PdfViewer/SelectionRenderer/SelectionRenderer.tsx (1)

57-61: LGTM! Clean consolidation of selection string clearing logic.

Moving setSelectionString("") to the start of the main effect elegantly handles both cases: clearing when selectedBlocks becomes empty (via early return) and resetting before reprocessing when blocks exist. This removes the need for a separate effect and ensures no stale selection text persists when a note is active.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Visual Regression Test Report ✅ Passed

Github run id: 20530281972

🔗 Artifacts: Download